radio test improements #50
Conversation
krish2718
force-pushed
the
rt_improvs
branch
2 times, most recently
from
8ae1fef to
0fa6a82
Compare
krish2718
requested review from
sachinthegreen,
bama-nordic,
prsi98,
srkanordic and
kspraveeen
| @@ -996,6 +1037,7 @@ static int nrf_wifi_radio_test_set_tx(size_t argc, const char *argv[]) { | |||
|
|
|||
| if (status != NRF_WIFI_STATUS_SUCCESS) { | |||
| RT_SHELL_PRINTF_ERROR("Programming TX failed\n"); | |||
| ctx->conf_params.tx = !val; | |||
There was a problem hiding this comment.
This might cause an issue where a test is NOT running and the user issues a TX stop (erroneously). We seem to be missing a check in the beginning to catch this scenario. If now the nrf_wifi_rt_fmac_prog_tx too fails then the state will get set to TX running.
There was a problem hiding this comment.
it will still work, as the API won't fail if the test is not running, no? (we can add a check independent to this).
There was a problem hiding this comment.
I tried to do wifi_radio_test tx_tone 0 without starting and the command timeout, like most other commands FW doesn't send an event if its a no-op, so, we need a fix in OSAL code for that to avoid sending CMD if it's a no-op, but this is unrelated to the issue that customer has reported.
This is helpful in trying multiple iterations and having finer control over nRF70 init rather esp. when switching modes or recovery. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Clear only on success, helps in dealing with multiple tests in a sequence. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
Only nRF70 is deinitialized then the config is no longer relevant. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
No description provided.