Matter upmerge to 1.2.0.1 version #346
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated by '[Scenes] Enabling TableSize feature (#29762)' Signed-off-by: Jaehoon You <jaehoon.you@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com>
* Change java generated files using jinja * Restyled by autopep8 * modify test app list --------- Co-authored-by: Restyled.io <commits@restyled.io>
This commit changes the default value of the UDP listen port used in Android platform's ControllerParams from 5541 to 0. Since the default value of UDP listen port was 5541, if multiple matter applications using default settings are run on one matter device, UDP listen port conflict occurs. If we set the UDP listen port to 0, port collisions can be avoided because the port is bound randomly. Although matter applications can avoid conflicts by setting a UDP listen port, it is better to set this to its default value of 0 so that matter applications that use the default settings can avoid conflicts. Signed-off-by: Youngho Yoon <yhoyoon@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com> Signed-off-by: sanghyukko <sanghyuk.ko@samsung.com> Signed-off-by: Jaehoon You <jaehoon.you@samsung.com> Signed-off-by: Kyu-Wook Lim <kyuwook.lim@samsung.com>
* Fix streamer_esp32.cpp for current esp-idf main branch * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [NXP] Adding Matter support for RW61x platform * [NXP] Updating ot-nxp submodule to support RW61x * [RW61x] Fix misspell errors * [RW61x] Fix code-lints errors and updating zap generation : expose the EndpointList attribute in PowerSource cluster * [RW61x] Fix build-and-publish errors * [RW61x] Reworking all-clusters README.md to fix build-and-publish errors * [NXP] Fix application build : Adding device_layer_target_define for NXP device platform * [NXP] Addressing review comment : Removing unnecessary factory reset at ConfigurationManagerImpl init * [NXP] Updating zap files * [NXP] Fix all-clusters app build : update path of ErrorStr.h * [NXP] Run clang-format on RW61x/COMMON sources * Restyled by whitespace * Restyled by clang-format * Restyled by gn * Restyled by prettier-markdown --------- Co-authored-by: Restyled.io <commits@restyled.io>
* Move xml to say zapxml since that is the format * Start defining a data_model_xml parser (no functionality for now) * Start adding some basic support for data model xml parsing * make the DM parser executable * Start having the ability to parse clusters * More updates, we seem to have parsing for features * Hard-code global attributes * Remove some comments * Add enumeration handling * Add bitmap handling * Restyle * Parse structs * Re-organize parsing a bit * Make a linter happy * Another linter fix * Handling of events * More handling and logic on events * Add support for access privilege parsing * XMLs have maybe invalid enum entries. Handle them gracefully * More attribute handling updates * restyle * Support deprecate constraint * Support constraint decoding, apply on attributes for now * Restyle * Restyle * Field handling * Field handling * Some bug fixing * Start adding command handling * Restyle * Name normalization and more parsing updates * Name normalization and more parsing updates * Better messaging and fix constraint types * Restyle * Start creating a IDL codegen so we can self-test parsed output * Start with listing clusters * Enum listing * A lot more things supported * Attribute rendering * Support for string and octet string sizes * Timed command support * Restyle * Add descriptions to clusters * Attempt to fix up alignment of things * Alignment looks slightly better * Better command separation * Align comments * Align and output descriptions including clusters * More work regarding loop structures * Apply hex formatting to bitmaps. output now seems identical except one whitespace change * Identical output for now * Support API maturity. Notice that doccomments are lost on maturity :( * Fix doxygen parsing for api maturity at the cluster level * Restyle * Support endpoints, although that is not 1:1 as hex encoding and ordering for events is lost * Restyle * Add todo note that default value does not string escaping * Default rendering and add to files * More updates on file dependencies * Unit test IDL generator * Add the IDL unit test as a standard unit test * Update for python compatibility * Fix unit testing of builds when GSDK root is defined * Added a readme file * Restyle * Make xml parser use the idl codegen * Restyle * look to fix misspell warnings * Undo repo update * Fix linter errors * Codegen as idl for data_model_xml_parser.py * Parsing closer to matter idl content * more normalization and type processing * More mandatory conformance logic * Fix mandatory conditionals * Make unit test pass * Fix tests a bit more and make parsers better * Restyle * Ignore min/max values while parsing xmls, even though raw data internally contains them * Restyle * Fix space after click annotations * Compare support for human reviews * Restyle * Fix slash * Undo submodule change * fix xml to zapxml naming changes * Restyle * Update dates from 2022 to 2023 * Add note about the complex test input * Remove unused imports * Restyle * Add some commends based on code review * Add heuristic for setting enum and bitmap sizes, to make output from XML much more readable * Add support for timed and fabric scoped commands * Add missing import --------- Co-authored-by: Andrei Litvin <andreilitvin@google.com>
* [Ameba] added implementation for manual operation of several clusters (dishwasher alarm, refrigerator alarm, operational state, rvc operational state, rvc runmode, and rvc cleanmode), test event trigger for smoke alarm, shutdown function of CHIPDeviceManager, and init laundrywashercontrolserver * [Ameba] Run restyle-diff.sh, and modified cmake configuration to add additional implementation * [Ameba] Added CONFIG_ENABLE_AMEBA_TEST_EVENT_TRIGGER macro * [Ameba] added CONFIG_ENABLE_AMEBA_TEST_EVENT_TRIGGER define flag at cmake * [Ameba] Updated switch case at ManualOperationalStateCommand.h and updated raise and lower alarm function at ManualDishWasherAlarmCommand.h * [Ameba] Updated RvcOperationalState::ErrorStateEnum::kUnknownEnumValue to OperationalState::ErrorStateEnum::kUnknownEnumValue because it was removed, and added minor comments.
Signed-off-by: Chin-Ran Lo <chin-ran.lo@nxp.com>
* Remove PSA Crypto exclusion * fix PSA test failure * Add more comments * Fix comments * Add isKeySet flag * address comments
This change adds shutdown to AndroidDeviceControllerWrapper, which wraps CHIPDeviceController on the Android platform, so that DeviceControllerFactory and CHIPDeviceController can be shutdown. AndroidDeviceControllerWrapper initializes DeviceControllerFactory and CHIPDeviceController, but since it supports only CHIPDeviceController shutdown, DeviceControllerFactory shutdown is required. If you reuse AndroidDeviceControllerWrapper with the call below without shutting down DeviceControllerFactory, sometimes the DeviceControllerSystemState of DeviceControllerFactory becomes incorrect, causing AndroidDeviceControllerWrapper to operate incorrectly, and the problem cannot be solved unless the process is restarted. - AndroidDeviceControllerWrapper::AllocateNew() - AndroidDeviceControllerWrapper::Controller()->Shutdown() Signed-off-by: Youngho Yoon <yho.yoon@samsung.com> Signed-off-by: Charles Kim <chulspro.kim@samsung.com> Signed-off-by: Hunsup Jung <hunsup.jung@samsung.com> Signed-off-by: sanghyukko <sanghyuk.ko@samsung.com> Signed-off-by: Jaehoon You <jaehoon.you@samsung.com> Signed-off-by: Kyu-Wook Lim <kyuwook.lim@samsung.com>
Bumps [third_party/pigweed/repo](https://github.com/google/pigweed) from `9504c03` to `fbb318a`. - [Commits](google/pigweed@9504c03...fbb318a) --- updated-dependencies: - dependency-name: third_party/pigweed/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/openthread/repo](https://github.com/openthread/openthread) from `66eaeec` to `837c7fd`. - [Release notes](https://github.com/openthread/openthread/releases) - [Commits](openthread/openthread@66eaeec...837c7fd) --- updated-dependencies: - dependency-name: third_party/openthread/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…n board 917 NCP (#29884) * Added changes for the power cycle issue * Added changes for only 917 NCP and firmware version print * fix for build errors * Removed the changes for dissconnect event * Restyled by whitespace * Restyled by clang-format --------- Co-authored-by: yap <Yaminidevi.P@silabs.com> Co-authored-by: Restyled.io <commits@restyled.io>
* Update tag test to include root and omit content app * Restyled by isort * Fix test of the test One line got missed in the commit. --------- Co-authored-by: Restyled.io <commits@restyled.io>
* [Telink] Use -p for activate to install requirements.telink.txt * Update builds to docker version 22 * [Telink] try to use new variable for path --------- Co-authored-by: Andrei Litvin <andy314@gmail.com>
TC-CADMIN-1.4 TC-CADMIN-1.6 TC-CADMIN-1.10 TC-CADMIN-1.16 TC-CADMIN-1.21 TC-CADMIN-1.22 TC-CADMIN-1.23 TC-CADMIN-1.24
Bumps [third_party/libwebsockets/repo](https://github.com/warmcat/libwebsockets) from `18fdb0d` to `a1cbc02`. - [Commits](warmcat/libwebsockets@18fdb0d...a1cbc02) --- updated-dependencies: - dependency-name: third_party/libwebsockets/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/ot-br-posix/repo](https://github.com/openthread/ot-br-posix) from `636e53d` to `69ce2a5`. - [Release notes](https://github.com/openthread/ot-br-posix/releases) - [Commits](openthread/ot-br-posix@636e53d...69ce2a5) --- updated-dependencies: - dependency-name: third_party/ot-br-posix/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Bumps [third_party/nanopb/repo](https://github.com/nanopb/nanopb) from `a4bbd6a` to `9766c45`. - [Commits](nanopb/nanopb@a4bbd6a...9766c45) --- updated-dependencies: - dependency-name: third_party/nanopb/repo dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This triggers the spell checker when I generate the test plans.
* Initialize CHIP stack before running app tests * Patch add_entropy_source() to make it idempotent * Do not add entropy source more than once
* [nrfconnect] Pushed downstream patches to align with v2.5.0 Pushed all downstream patches aligning nrfconnect platform to the nRF Connect SDK 2.5.0 version: * Added support for new Wi-Fi dongle board. Added enabling Wi-Fi support in Matter if nRF7002 EB is selected as a shield. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * Turn off wpa_supplicant debug output. This saves ~20kB of FLASH. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [nrfconnect] Enable zcbor explicitly for mcuboot Mcuboot requires zcbor, so enable it explicitly, otherwise the build fails with latest mcuboot. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> * [nrfconnect] Align with the upstream net_if API change net_if_ipv6_maddr_join() now requires to provide a net_if pointer. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no> * config: nrfconnect: Remove PSA_WANT default n setting With PSA_WANT configurations being default n then these default values are no longer needed for chip-module. Signed-off-by: Joakim Andersson <joakim.andersson@nordicsemi.no> * [zephyr] Add config to enable watermarks support Added a config to control enabling support for heap watermarks within the Zephyr platform. * Fixed Wi-Fi re-connection mechanism. Do not force the Disconnect() if the wpa_supplicant recovered the connection by itself. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Disabled BLE GATT caching This commit disables BLE Gatt caching for nRF Connect SDK platform. Signed-off-by: Duda, Łukasz <lukasz.duda@nordicsemi.no> * Enabled erasing NVS as default method This commit configures FW to erase flash pages occupied by non-volatile storage when a factory reset is requested, instead of removing Matter-related settings only. Signed-off-by: Duda, Łukasz <lukasz.duda@nordicsemi.no> * Disable shell for OpenThread and HWINFO module This commit reduces the overall memory consumption by disabling the OpenThread shell and HWInfo module. Signed-off-by: Duda, Łukasz <lukasz.duda@nordicsemi.no> * Align finding Python3 executable to NCS requirements. We should try to find Python3 instead of Python within cmake scripts. * Enable Generating Onboarding Codes by default This PR enables automatic generation of onboarding codes to the build directory when Factory Data feature is enabled. * Enable minimal configuration of Shell Enable minimal shell configuration to save some ROM and RAM. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * Fixed boot reason for nRF52 Recently the mechanism of nRF52 reboot type retention which is used in Matter has been deprecated in Zephyr and can be only bring back by a dedicated KConfig. Another solution (chosen) is to explicitly store boot reason in the retention registers for both nRF52 and nRF53. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Increased number of net sockets poll max Increased CONFIG_NET_SOCKETS_POLL_MAX from 4 to 6, as otherwise it resulted in bus fault during connection. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * Remove recovery mechanism for Wi-Fi connection Currently, the Wi-Fi driver supports the recovery mechanism and it seems that it works properly so we can remove our recovery mechanism when the connection is lost. Apart from losing the network, we need to leave the recovery mechanism to work after the device's reboot because we need to scan periodically to find a known network. * Increase the maximum number of prefixes to match the maximum number of IPv6 addresses per interface. Zephyr ipv6_nbr implementation requires the given address to have a matching prefix set on the interface. Otherwise, the default router is used for sending neighbor advertisement and as a result, in case there are multiple routers in the network, the packet can be sent to the invalid interface (not the one which issued neighbor solicitation). Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * [nrfconnect] Enable NVS lookup cache settings optimization By default, use the lookup cache hash function optimized for NVS used as the settings backend. This assumes that a user application uses Zephyr settings API and does not write to the NVS directly. * Disable nRF70 driver logs verbosity by default. This aims to keep memory footprint after this config is enabled by default in NCS. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no> * Disabled BLE 2M PHY due to interoperability issues There were some interoperability issues discovered due to BLE PHY dynamic changes from 1M to 2M. The 2M was disabled to ensure the interoperability with some of the BT controllers. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * Disabled Wi-Fi logs to save flash Recently some new Wi-Fi logs were enabled by default. These need to be disabled to decrease memory footprint. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> * [nrfconnect] Fixed door lock feature map Door lock sample has incorrect feature map value, because it is hardcoded in cpp file, instead of using the value generated from the .zap file. * [nrfconnect] Fixed window covering attributes default values Implemented post cluster init callback to set null values to 0, if any other value was not saved in NVS. * [nrfconnect] Disabled BOOT BANNER for release configuration * Align codebase with the new callback format Align NCS codebase with the new struct mgmt_callback format. * Restore IPC thread priority in Matter samples We noticed that IPC priority on nRF5340 is not set by default. We need to set it in DTS to be sure that the IPC thread does not collide with other threads. * Enable build with the factory data support. This PR enables factory data generation and usage by default in all NCS Matter samples. * Fix missing mcumgr header Header img_mgmt.h added to source file. * Forced using minimal libc for mcuboot image Minimal libc selection has to be forced for all Matter-related mcuboot builds. Otherwise the picolib is enabled and image size increases by several k, so it cannot fit in the dedicated partition. * Add bootutil for image definitions Adds building bootutil, when DFU with MCUmgr is enabled, for application image definitions. * [zephyr] Track number of enqueued platform events Add a new system statistic for tracking the number of enqueued platform events and update it in Zephyr platform. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> * Optimize RAM usage - Reduce number of network buffers and packets This commit reduces the number of network buffers and packets used by the nrfconnect platform. - Add support for printing mbedTLS heap This commit adds support for printing the peak usage of mbedTLS heap. - Reduce number of Matter stack packet buffers This commit reduced the number of available Matter's packet buffers to 8 which affects RAM usage. - Introduce KConfig option to enable RAM profiling This commit introduces the KConfig option that enables a set of features useful for profiling the RAM memory. - Disable SSL server support for Matter This commit dissables unused support for SSL server. - Reduce size of platform event queue This commit overwrites the default size of platform event queue and sets it to 64. - Reduce mbedTLS heap and OpenThread stack sizes This commit reduces the mbedTLs heap and OpenThread stack sizes when Joiner role is enabled by not used (case of OT libraries). - Reduce kernel heap size for Matter over Wi-Fi This commit aligns the default heap size to the value used in the Shell example. - Optimize buffer usage of nRF700X driver for Matter Matter device does not need to operate as high-performance STA, and so this commit reduces the default number of buffers. As a result the heap used by the supplicant may be significantly reduced. - Added the missing conditions to HEAP configs. Decrease stack sizes according to the peak results Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no> * Increase stability of Wi-Fi LPM operations This commit increases number of TX Tokens to the previous value of 10 to prevent RPU stalls. Additionally it was observed that 500ms delay before executing factory reset is too small for certain situations on Wi-Fi. This commit also increases this delay to 1s. Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> * [openthread] Aligned to CSL method API changes With the most recent OpenThread version, the API for CSL methods changed, so it had to be aligned in the Matter SDK. Added alternative implementation depending on the OpenThread API version. * [nrfconnect] Updated nRF Connect SDK to 2.5.0 Updated nRF Connect SDK version to 2.5.0 and updated all docker images version to the 24. * Restyled by whitespace * Restyled by clang-format * [shell] Fixed wrong condition for mbedtls include Changed if defined() to if statement to fix missing mbedtls header file for platforms using CHIP_CRYPTO_MBEDTLS = false * [nrfconnect] Disabled factory data for all clusters app The default prj.conf build does not use partition layout with factory data partition included, so the factory data support has to be disabled. * Addressed review comments * Moved MINIMAL_LIBC config to mcuboot defaults * Brought back setting lock feature map, but changed the value from 0x101 to 0x181 (added COTA support) Additionally fixed Zephyr unit tests: * Changed main return type from void to main for Zephyr unit tests runner. * Added decreasing pool size conditionally to not affect tests * Fixed exiting the tests to prevent abort. --------- Signed-off-by: Łukasz Duda <lukasz.duda@nordicsemi.no> Co-authored-by: Restyled.io <commits@restyled.io>
Add Zephyr module manifest in the CHIP root directory in order to automatically pull CHIP into a project when CHIP is one of the submodules specified in west manifest. CHIP module takes all compilatinon flags associated with the zephyr_interface target and passes them to the external GN-based project. For that reason we must ensure that the Matter module is processed after other revelant modules that modify the zephyr_interface target. nrfxlib is such a module as it contains nrf_security which carries the mbedtls configuration. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Add a manually triggered workflow for building Android CHIPTool packages for arm and arm64 architectures, CHIP Tool for Linux x64 and arm64, and OTA provider for Linux. The packages are uploaded both as github artifacts and release packages (as the latter require a release tag). The doxygen workflow pushes doxygen HTML files to another branch which is undesired on the sdk-connectedhomeip fork as it causes significant growth of the repository size. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Remove Android Chip Tool from release workflow Android Chip Tool is no longer maintained so it must be removed from the release workflow. Remove dependency to openssl from CHIP tool build for linux Currently the chip-tool that is released as a part of sdk-connectedhomeip has dependency to openssl. The issue is that Ubuntu 20.04 and Ubuntu 22.04 use different version of OpenSSL and version built under 20.04 does not work under 22.04 (without some hacks to install the old openssl version) and vice-verse. - Removed the dependency to the dynamic library (OpenSSL) to build Chip-Tool with the mbedTLS.
Set for CI build NCS recommended version to origin/main
Make building nRF Connect examples optional in github workflows in a sense that they do not fail the workflow if they do not compile. The reason is that the CI is often run for downstream patches, that are required to proceed with changes in NCS or Zephyr and we do not want to force developers to update examples in sdk-connectedhomeip at that moment - they will be updated in the upstream later. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Make chip_data_model.cmake correctly determine CHIP_ROOT constant if that is not defined in the application CMake. Also, use Python3 selected by CMake. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
pigweed_environment.gni file is included by GN scripts used by Matter build system. The file is generated by bootstrap.sh script but in nRF Connect SDK we do not want to force user to run that script. Therefore, include a copy of that file in tree. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
The helper script is going to find recommended ZAP version in the Matter repository, and download and extract the package from the ZAP releases. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Signed-off-by: Michał Szablowski <michal.szablowski@nordicsemi.no>
Allow to bypass codegen at build time. Re-add removed callback-stub.cpp and plugin callback templates Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no> Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
If CHIP_SHELL is enabled, the GN adds dependency to controller files, what results in invoking zap-cli. We want to bypass usage of zap-cli in our samples builds, so the dependency was removed for the nrfconnect platform. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
Currently, in sdk-connectedhomeip we don't need to run upstream's workflows for all platforms because we use sdk-nrf workflows to verify our PRs. We decided to remove all of them except Lint Code Base and Unit Tests from the 'pull request' and 'push' triggers and leave the possibility to run them manually. This commit cannot be pushed to the Matter upstream repository!
It runs on the upstream repository and updates dependencies accordingly.
The zap executable location in script and printed path are not correct.
Last changes and upmerges cause instabilities in our workflows actions. This commit repairs unit tests.
This commit fixes building on Windows PowerShell by removing usage of "bash" command. Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
Usage of generate.py script is not possible on windows due to fcntl package available onlu on unix pyhton packages using I/O control on descriptor file is not needed on windows. This change enhance script to use fcntl on non-window system.
Stop filtering out gdwarf-4 when passing flags from Zephyr to Matter's GN build system. Older pyelftools versions are not able to parse DWARF5 format, so ram and rom report would not be generated. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no> Signed-off-by: Lukasz Duda <lukasz.duda@nordicsemi.no>
Enhance attaching to Thread by verifying if the current dataset is the same as provided. In current solution implementation will not reset the Thread interface while the dataset are equal to the active dataset. Signed-off-by: Michał Szablowski <michal.szablowski@nordicsemi.no>
It's pointless to issue a connect request in case no valid SSID has been found. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
Fix the build of Matter samples with sys_heap malloc enabled. The linker errors would occur because: 1. The realloc() function is not used outside the LTO- optimized code. 2. Thus, the LTO linker plugin would mark __wrap_realloc symbol as PREVAILING_DEF_IRONLY, which would enable the compiler to optimize away the function. 3. As a result, undefined references to realloc() could not be resolved by the linker. Mark malloc/calloc/realloc/free as externally visible. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
libCHIPShell.a is already part of libCHIP.a but the former had to be linked additionally with --whole-archive flag to process the shell and init objects defined with SHELL_XXX and SYS_INIT Zephyr macros and, in turn, register Matter shell commands properly. This symbol duplication between the two libraries causes issues when building Matter with LTO, so replace the current approach with explicitly pulling in one symbol from MainLoopZephyr.cpp file. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Now the API to manage GPREGRET register is unified for all devices having one or more GPREGRET entries. Signed-off-by: Nikodem Kastelik <nikodem.kastelik@nordicsemi.no>
Wi-Fi stack recently introduced a check for valid band value and the default value of 0 (memset) means only 2.4GHz, so, 5GHz Wi-Fi associations will fail. Fix the default to Unknown to scan all supported bands. Fixes KRKNWK-18035. Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This commit changes zephyr kconfig deprecated symbols. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
The URLs for the ZAP tool binaries changed, so script for downloading it had to be aligned. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
kkasperczyk-no
force-pushed
the
matter_upmerge_1_2
branch
from
d2a70db to
1a5e5e5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regular upmerge of Matter fork to v.1.2.0.1