[nrf noup] Directed network scan implementation #408
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markaj-nordic
requested review from
markaj-nordic,
Damian-Nordic,
kkasperczyk-no and
ArekBalysNordic
and removed request for
kkasperczyk-no
Damian-Nordic
approved these changes
Mar 13, 2024
| @@ -188,6 +188,13 @@ CHIP_ERROR WiFiManager::Scan(const ByteSpan & ssid, ScanResultCallback resultCal | |||
| mWiFiState = WIFI_STATE_SCANNING; | |||
| mSsidFound = false; | |||
|
|
|||
| if ((ssid.size() > 0) && (!mInternalScan)) | |||
| { | |||
| mDirectScanNetwork.Erase(); | |||
There was a problem hiding this comment.
I guess we could reuse mWantedNetwork and simplify the implementation but doesn't matter for now ;)
Implementation of directed scanning, to adjust to newer matter version specification. Signed-off-by: Patryk Lipinski <patryk.lipinski@nordicsemi.no>
LipinskiPNordicSemi
force-pushed
the
directed_scaning
branch
from
9f439af to
35b85dd
Compare
ArekBalysNordic
approved these changes
Mar 13, 2024
|
Closing as #412 seems to have more advantages. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of directed scanning, to adjust to newer matter version specification.