[nrf toup][nrfconnect] Fixed mcuboot default configuration #432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkasperczyk-no
requested review from
LuDuda,
Damian-Nordic,
ArekBalysNordic and
markaj-nordic
markaj-nordic
approved these changes
Apr 23, 2024
LuDuda
approved these changes
Apr 23, 2024
Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: * BOOT_ENCRYPT_X - are configs without a prompt, so it should not be modified outside of the mcuboot module * SPI_NOR and NORDIC_QSPI_NOR - are set based on the device tree configuration, so we should not set it, as it may lead to configuration and dts mismatch. Signed-off-by: Kamil Kasperczyk <kamil.kasperczyk@nordicsemi.no>
kkasperczyk-no
force-pushed
the
mcuboot_configs_fix
branch
from
3b49730 to
6dcff41
Compare
|
@jaci-nordic I think that the workflow you've just added (#431) is failing. Any clue how to solve it? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed the defaults from Kconfig.mcuboot.defaults configuration that should not be set there: