[nrf toup] VerifyOrDie logging for constrained devices #465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Damian-Nordic
commented
Jul 24, 2024
Damian-Nordic
commented
- Add the configuration to enable logging the location of a failed VerifyOrDie() without logging the condition to reduce the code size impact but still be able to debug failing VerifyOrDie() conditions.
- Allow to override FILE macro with FILE_NAME by setting the warn_builtin_macro_redefined GN arg to false to further reduce the code size increase.
- Add Kconfigs for nRF Connect platform for enabling both features.
Damian-Nordic
requested review from
LuDuda,
kkasperczyk-no and
ArekBalysNordic
and removed request for
LuDuda and
kkasperczyk-no
Damian-Nordic
commented
Jul 24, 2024
1. Add the configuration to enable logging the location of a failed VerifyOrDie() without logging the condition to reduce the code size impact but still be able to debug failing VerifyOrDie() conditions. 2. Allow to override __FILE__ macro with __FILE_NAME__ by setting the warn_builtin_macro_redefined GN arg to false to further reduce the code size increase. 3. Add Kconfigs for nRF Connect platform for enabling both features. Signed-off-by: Damian Krolik <damian.krolik@nordicsemi.no>
Damian-Nordic
force-pushed
the
verify_or_die
branch
from
bc7fd4c to
6852524
Compare
kkasperczyk-no
approved these changes
Jul 25, 2024
ArekBalysNordic
approved these changes
Jul 25, 2024
LuDuda
approved these changes
Jul 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.