Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nrf toup][nrfconnect] Added BT reassembly config to BT SMP samples #470

Closed

Conversation

HubertHugo
Copy link
Contributor

This PR adds BT reassembly config to SMP DFU samples as it is recommended

@NordicBuilder
Copy link

none

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@markaj-nordic
Copy link
Contributor

Maybe it's better to first add it to upstream and then pull in as [nrf fromtree.]

@HubertHugo
Copy link
Contributor Author

Maybe it's better to first add it to upstream and then pull in as [nrf fromtree.]

@markaj-nordic I don't know what are pluses and minuses of this approach so I can change it if you guys agree on that.

@markaj-nordic
Copy link
Contributor

Maybe it's better to first add it to upstream and then pull in as [nrf fromtree.]

@markaj-nordic I don't know what are pluses and minuses of this approach so I can change it if you guys agree on that.

For me the rule of thumb for [toup] is the need of urgent patch/fix in our SDK. This change is just a minor improvement, so I'd suggest to go upmerge first. On the other hand, it's just our platform being affected, so I maybe I'm too picky.

@HubertHugo HubertHugo closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants