[nrf toup][nrfconnect] Refactor ExternalFlashManager #475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 11, 2024
maciejbaczmanski
requested review from
LuDuda,
doublemis1,
kkasperczyk-no,
ArekBalysNordic and
markaj-nordic
kkasperczyk-no
approved these changes
Sep 11, 2024
maciejbaczmanski
force-pushed
the
matter_flash_manager
branch
2 times, most recently
from
d688ddf to
c7dd17b
Compare
maciejbaczmanski
force-pushed
the
matter_flash_manager
branch
from
c7dd17b to
7a3e2a6
Compare
Make `ExternalFlashManager` a singleton Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
force-pushed
the
matter_flash_manager
branch
from
7a3e2a6 to
1dafe76
Compare
markaj-nordic
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
ExternalFlashManagera singleton and moveDoActionimplementation toExternalFlashManager.cpp