-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove unused submodules #566
Conversation
1f4a2c5
to
ad61876
Compare
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
ad61876
to
a1cf816
Compare
.gitmodules
Outdated
@@ -27,321 +18,22 @@ | |||
path = third_party/openthread/repo |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we even need openthread repo there? We actually use openthread from Zephyr.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Build system is complaining when it's not there. I will check if I can get rid of it easily.
path = third_party/silabs/wifi_sdk | ||
url = https://github.com/SiliconLabs/wiseconnect.git | ||
branch = v3.3.3 | ||
platforms = silabs | ||
[submodule "editline"] | ||
path = third_party/editline/repo | ||
url = https://github.com/troglobit/editline.git | ||
[submodule "third_party/boringssl/repo/src"] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this used for some tests? I though that we use PSA or Mbedtls only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We use boringssl
to build tools.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, we can switch to, for example, mbedtls while building tools by adding an additional argument, chip_crypto
. I don't know how big a gain is, but still something more to remove. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think mbedtls
does not support some feature that we need in one of the tools, so we need openssl
or boringssl
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, so leave it as it is :)
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
This reduces size of the repo to ~1.8GB.