Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused submodules #566

Merged
merged 2 commits into from
Mar 4, 2025
Merged

Conversation

adigie
Copy link
Member

@adigie adigie commented Mar 3, 2025

This reduces size of the repo to ~1.8GB.

@adigie adigie requested a review from a team as a code owner March 3, 2025 13:20
@adigie adigie force-pushed the remove-some-submodules branch 7 times, most recently from 1f4a2c5 to ad61876 Compare March 3, 2025 15:06
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
@adigie adigie force-pushed the remove-some-submodules branch from ad61876 to a1cf816 Compare March 3, 2025 15:06
@adigie adigie changed the title Remove some submodules Remove unused submodules Mar 3, 2025
.gitmodules Outdated
@@ -27,321 +18,22 @@
path = third_party/openthread/repo
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we even need openthread repo there? We actually use openthread from Zephyr.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Build system is complaining when it's not there. I will check if I can get rid of it easily.

path = third_party/silabs/wifi_sdk
url = https://github.com/SiliconLabs/wiseconnect.git
branch = v3.3.3
platforms = silabs
[submodule "editline"]
path = third_party/editline/repo
url = https://github.com/troglobit/editline.git
[submodule "third_party/boringssl/repo/src"]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this used for some tests? I though that we use PSA or Mbedtls only.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We use boringssl to build tools.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, we can switch to, for example, mbedtls while building tools by adding an additional argument, chip_crypto. I don't know how big a gain is, but still something more to remove. :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think mbedtls does not support some feature that we need in one of the tools, so we need openssl or boringssl.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, so leave it as it is :)

Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
@rlubos rlubos merged commit 80665b6 into nrfconnect:master Mar 4, 2025
8 checks passed
@adigie adigie deleted the remove-some-submodules branch March 4, 2025 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants