[nrf toup][nrfconnect] Add --full flag to zap-generate and parametrize app-common zap-generated path
#567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maciejbaczmanski
force-pushed
the
matter_zap_west_tools
branch
from
777423b to
f81ddc6
Compare
* [app] Parametrize app-common zap-generated path Parametrize app-common zap-generated path to allow building Matter using custom generated zap files stored in different path. When user adds custom clusters, full zap regeneration is needed. Storing these files in fixed place requires regeneration every time user wants to build different project (with different clusters). This commit allows to store zap-generated files separately and provide their path by seting `CHIP_APP_ZAP_DIR` cmake and `chip_app_zap_dir` GN flags. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no> * [nrfconnect] Allow switching `CHIP_APP_ZAP_DIR` by cmake. Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no> --------- Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no> (cherry picked from commit a4530cbd8f3241355f232f7d23016eb5c57f6f3f)
Add a `--full` flag that generates full data model and puts it it `app-common/zap-generated` subdirectory. Additionaly fix minor bug when equal paths have been shown as non- relative and zap file is not properly updated with zcl.json file Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
maciejbaczmanski
force-pushed
the
matter_zap_west_tools
branch
from
f81ddc6 to
6cc75a9
Compare
maciejbaczmanski
changed the title
--full flag to zap-generate--full flag to zap-generate and parametrize app-common zap-generated path
adigie
approved these changes
Mar 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a
--fullflag that generates full data model and puts it itapp-common/zap-generatedsubdirectory.Additionaly fix minor bug when equal paths have been shown as non- relative and zap file is not properly updated with zcl.json file
Also pull commit [nrf fromtree] Parametrize app-common zap-generated path from upstream