Fix zap-gui and add zap-install #579
Conversation
scripts/west/zap_gui.py
Outdated
| was_updated = update_zcl_in_zap(zap_file_path, zcl_json_path, app_templates_path) | ||
| if args.cache and was_updated: | ||
| log.wrn("ZCL file path in the ZAP file has been updated. The ZAP cache must be cleared to use it.") | ||
| if zap_file_path is not None: |
There was a problem hiding this comment.
Why? If someone provides zap_file_path manually, the zcl path inside it must be updated as well. Otherwise, the Zap tool gets the wrong paths, and, for example, new clusters are not taken into account. Moreover, I don't see an advantage of using this script outside the sample's directory. Our documentation is about this approach.
There was a problem hiding this comment.
Because currently it just fails and print traceback. You can still open specific file when provided path with -z argument.
I added this to just ignore the ZAP file if it's not found and open the GUI. Please see Damian's comment.
There was a problem hiding this comment.
The problem is if someone wants to open zap GUI externally, not from the sample's directory and zap file doesn't exist, then adding zcl path won't work. So, it is ok, but we should add a note to the guide for that because it may lead to problems. Alternatively, what seems better, we should prevent using the --zcl argument if we call without providing a zap file.
There was a problem hiding this comment.
@adigie I think you can restore the previous version and just not support this use case anymore. I might have missed that this command got more complex and is now doing more than a single thing, so maybe let's not complicate it further :). Sorry for the confusion!
There was a problem hiding this comment.
Restored previous version, west zap-gui will print ERROR: ZAP file not found! and exit if it finds no ZAP file.
Log error and return if ZAP file was not found Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Add west command to install ZAP Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
No description provided.