Cherry-pick changes from v1.4 branch #582
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is after openthread/ot-br-posix#2574 removed the log line we were looking for. Co-authored-by: Andrei Litvin <andy314@gmail.com> Co-authored-by: Andrei Litvin <andreilitvin@google.com> (cherry picked from commit 61f0ef1853ec5e8543035ecbbb146839594fa338) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…te matter-devices.xml (#36441) (cherry picked from commit dee7d7bf629ca416ec0fa0b1ef8c9b22debde7c9) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…#36490) (#36541) (cherry picked from commit 6569701de54b1d86848417d3ca0abfdaba8a36ad) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…(#36585) (cherry picked from commit bd89beaadb30b0be97550ccfcccee7d3450a679a) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…rt data provider (#36589) (#36593) * ESP32: fix typo to include correct Span.h in secure cert data provider * restyle (cherry picked from commit 3c3672992c1c4dac5d83a56340faa036a4df3c93) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…rds (#36606) (#36631)
remove the WORKING_DIRECTORY from chip_gn target
For cmake v3.31.x, custom command generated for chip_gn-build in
build.ninja concats the $WORKING_DIRECTORY and $BUILD_DIR paths and
it mess up the chip_gn step when building example.
COMMAND = cd "/Users/account/esp-matter/connectedhomeip/connectedhomeip/config/esp32/components/chip;/Users/account/esp-matter/examples/light/build/esp-idf/chip" && ninja esp32
For cmake version prior to v3.31, it do not prepend the
$WORKING_DIRECTORY path.
COMMAND = cd /Users/account/esp-matter/examples/light/build/esp-idf/chip && ninja esp32
This could be becuase of Kitware/CMake@f5f8030
related issue - espressif/esp-matter#1157
(cherry picked from commit 2b382d6357e9bfbb54f930d17156e79ed07091f3)
Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…er (#36710) (cherry picked from commit 9b008bc10d48bef1184cf9f0405b12b41af5d328) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* ESP32: Add support for ESP32-P4 * Restyled by clang-format * Restyled by prettier-yaml --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 43aa98c2d30ee547c6b587b9de7bbb794f175ece) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
Fix Carbon Monoxide Concentration Measurement cluster (cherry picked from commit 13380c7ef489fa4fa474ed296141409225a0a86d) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
(cherry picked from commit a07eef85283597c532241e1afb2308980c923f07) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…IP_DEVICE_CONFIG_ENABLE_TEST_SETUP_PARAMS (#36945) (#36951) (cherry picked from commit 8323b1b5d2588635f0da061447349e48d88283f5) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
(cherry picked from commit ad776f0bb5f1c3dbb1a2cc33b5eb13fb02d85f42) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…e chunking correctly. (#36975) (#37019) We were not propagating out encoding status, so when we reached end of packet we would just silently return CHIP_NO_ERROR instead of indicating we had more data to encode. Fixes project-chip/connectedhomeip#36882 (cherry picked from commit 5d21af8366a54d4842248c10a93be27fb04bbeff) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…without log (#37058) (#37069) * [ESP32]: increment the total operational hours inline without log Since total-operational-hours is a critical information, it intentionally uses the FreeRTOS timer to increment the values, so that it should not be a victim of PostEvent failures. Earlier it used to call WriteConfigValues which has the ChipLogProgress and logging from the timer stack may overflow the timer stack. So, inlined the implementation which do not log. * Restyled by clang-format * add reasoning behind the change as comment --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit c05637672dfad61be1054b8c229d2a585ac3b97c) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…ertification binaries (#37086) (cherry picked from commit cd07c4f5c3988258e6eba9d34d3dc0767d95e5a3) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
(cherry picked from commit ebf0be48787a05e85fdc904aca9dd361fdf8f81a) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…ClientInfo (#37180) * Added a public API to RefreshKeySender to retrieve ICDClientInfo * Added a public API to RefreshKeySender to retrieve ICDClientInfo * Restyled by clang-format * Restyled by clang-format --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 3e3d4eb7b6d0578785d58bce0b0266b7344ddf91) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…dpoint commands. (#37208) * Fix the bad endpoint logic in 1.4 * Undo submodule update * Back ported unit test * One more unit test * Update src/app/codegen-data-model-provider/CodegenDataModelProvider.cpp Co-authored-by: Terence Hampson <thampson@google.com> * Updated tests based on review comments * Fix includes * Address review comment: update listing of accepted/generated commands and unit test * Also fix Next calls * Update unit tests * Fix test --------- Co-authored-by: Terence Hampson <thampson@google.com> (cherry picked from commit f0a441fb4a14ed507c45c10b97bc86355ce13f70) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…#37264) (cherry picked from commit 6f1b823f30c456197edaa1e62e79b6f42d54a2df) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
… (#37326) * TCP tests: TC-SC-8.x - Use ArmFailsafe as cmd Also add top-level pics * Fix payload capability Co-authored-by: C Freeman <cecille@google.com> (cherry picked from commit fc00c97093b194e257faeead6a6f5b990a658f3f) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* TCP tests: TC-SC-8.x - Use ArmFailsafe as cmd (#37313) * TCP tests: TC-SC-8.x - Use ArmFailsafe as cmd Also add top-level pics * Fix payload capability * Fix for Bug #36732 (#36879) Set the app_state callback object in the Connection state to null when the CASE session object is being cleared, on top of setting the inner callback methods to null. This prevents the callback object from being accessed later, when the connection is getting closed(after the CASE session has been set up and the session object no longer exists). * Fix for Bug #36731. (#36880) Add CloseActiveConnections() call in TCPBase::Close(), which is called as part of Server::Shutdown(). Active connections should be closed as part of Server shutdown. This allows the TCPConnectionState to also close the associated TCPEndpoint object as part of this shutdown flow. Previously, the CloseActiveConnections() call was present in the TCPBase destructor alone. Add test for Connection Close() and checking for TCPEndPoint. --------- Co-authored-by: C Freeman <cecille@google.com> (cherry picked from commit 333824850e391b2f1d33f07cfbab74ea819e0ac7) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* Add 1.4.1 as a direct copy of 1.4 This can be used to see a diff between these two releases * Update alchemy version on 1.4 changes contraints - will update on tot soon, but don't want to wait for the PR to land before this goes in. * data model files at the 1.4.1 tag * Add 1.4.1 to parser with tests. * Restyled by isort * Fixup includes * Update 1.4 DM XMLs to latest (#37146) * Update 1.4 DM XMLs to latest * Fix CI checker so it properly checks spec_sha * DM XMLs: switch 1.4 to use alchemy (#37201) * Run dos2unix on all DM XML files in 1.4 * Add newlines at end of all DM XML files for 1.4 sed -i -e '$a\' data_model/1.4/device_types/* sed -i -e '$a\' data_model/1.4/clusters/* * DM XMLs: switch 1.4 DM XMLs to alchemy * Generator updates to alchemy * Update 1.4 using alchemy 1.5.0 * Restyled by autopep8 * Add the in-progress defines to match the 1.5 0.7 spec ballot * Fix define processing for alchemy, add tag file * Fix linter, add check for non-existent tag file * Remove a leftover file - this isn't generated by alchemy * Remove file from gni list --------- Co-authored-by: Restyled.io <commits@restyled.io> --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit f9f7909ac90755c759b42746d5889e1aa7c1b983) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…ification step document. (#37098) (#37440) * Test Steps 2, 3, 4, 2a, 3a, 4a, 2b, 3b, 4b,6, 7, 8, 10, 13 are updated with the boolean flag(SendInitMsgfromDUT ) true and false condition * Restyled by whitespace --------- Co-authored-by: Ashwini <98016634+Ashwinigrl@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit e0c8cbb3a55d4e2f6c0720d78ac87d2bda4b4133) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* [#36594] TC_SC_4_1, make BCM optional to meet test plan * [#36594] Remove new line * Restyled by prettier-yaml * Add ICDM.S.A0002 checking(#36597) * Restyled by prettier-yaml --------- Co-authored-by: simonhmorris1 <112178216+simonhmorris1@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 2cd02f9133a85e10969efa7c15487ad1d55d8900) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* Add test steps logging for TCP Tests * Fix naming of Test steps. (cherry picked from commit a0b659307e1b1e43a13b2671bda9ad6c614714d3) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…1.4.1 SVE (supports TCP) (#37429) * [TC-SC-4.3] Discovery [DUT as Commissionee] (#31982) * Adds TC_SC_4_3.py * Fixes TXT record not available when making direct query with name and type * Fixes restyle, adds comments to operational service logic * Fix restlye for mdns class * Adds get_service_types to mdns class * Fix restyle * Steps progress * Fix restyle * Fix restyle * Adds test to tests.yaml * Fix lint * Fix lit-icd-app path in tests.yaml * Fix SII key logic * Addresses latest review comments * Fix lint * Replaces 1 sec fixed sleep in operational service logic with service listener event wait time * Merge from master * MDNS class update progress * Adds MdnsAsyncServiceInfo class * Adds get_service_by_record_type to mdns class * TC progress * Fix restyle * Fix restyle * Fix lint * Fix restyle * tests.yaml from master * tests.yaml from master * Updates steps output and test runner configs * Adds tc to tests.yaml * Update * Updates to make a fresh question each time * Update progress * Fix restyle * Fix Lint * Fix restyle * Fix lint * Adds CI task tags * Completes step 11 * Fix restyled * Steps 8,11 * Fix restyled * Adds timeout to get_service_types * Updates get_service_types description * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Adds clarifying comment * Adds MCORE.COM PICS checks * Updates contains_ipv6_address * Removes listener dealy * Fix restyled * Fix restyled * Fix lint * Updates ipv6 check * Fixes ipv6 checks * Restore ms delay * continue * Step 9 - Updates hostname character length check, other adjustments * removes temp test file * Restyled by autopep8 * Removes test case YAML and manualTests.json reference * Fix restyle * Updates CI python test arguments * Fix typo * matter_testing import update * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Update src/python_testing/TC_SC_4_3.py Co-authored-by: C Freeman <cecille@google.com> * Addresses latest * Fix restyle * Testing zeroconf class imports * service info refactor * Fix restyle * Fix restyle * Updates mdns service info init * Fix restyle * Updates MdnsAsyncServiceInfo --------- Co-authored-by: C Freeman <cecille@google.com> Co-authored-by: Restyled.io <commits@restyled.io> * TC-SC-4.3: Clear cache before sending request (#37362) * Fix imports (changed post 1.4, before this test was written) * Move back to old style CI arguments --------- Co-authored-by: Raul Marquez <130402456+raul-marquez-csa@users.noreply.github.com> Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 1b5b4392a094306cd8f8fd6fac8ef202bf0ac099) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
(cherry picked from commit 19c3a7bdf2b32234746dee23e1b9a9a5ed1d41b3) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
…rmance test. (#37268) (#37465) * Change reference from TLV endpoint * Change test endpoint function * Fix issue with attr list * Add handling for TLV attributes Co-authored-by: Moises Terrones <moises.tersal@gmail.com> (cherry picked from commit de5c5e6040610a320ee30b9f1cf222e167bf6447) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
* Spec revisions: Update to 1.4.1 * TC-BINFO-2.1: Update for dot requirements * minor rewording * Restyled by prettier-yaml * Update expected value in test --------- Co-authored-by: Restyled.io <commits@restyled.io> (cherry picked from commit 9a00cb990ef57053f407f9c419d9ac29bfa21160) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
… version (#37394) and update general-commissiong cluster XML (#37447) * Auto-select data model set based on specification version (#37394) * Auto-select data model set based on specification version * Remove extra includes * Fix PICS test test to add SoftwareVersion with pics * Restyled by isort * linter * Omit TestSpecParsingSelection test from app testing --------- Co-authored-by: Restyled.io <commits@restyled.io> * linter * Omit new unit test from automated testing in old style * Add provisional General Commissioning Cluster TCUpdateDeadline attribute (#35903) * Added a new server-side optional attribute `TCUpdateDeadline` (code 0x09) to the General Commissioning Cluster XML. * This attribute is a 32-bit unsigned integer (`int32u`) and is marked as non-writable. * The attribute is defined as provisional with `apiMaturity="provisional"`. * It includes read access with the privilege set to administer. * Re-generated using ./scripts/tools/zap_regen_all.py * fix test selection to work with 1.4 import style * zap regen with the new xml --------- Co-authored-by: Restyled.io <commits@restyled.io> Co-authored-by: James Swan <122404367+swan-amazon@users.noreply.github.com> (cherry picked from commit a06a0f5af3bac60a0d88d586f29210ec9e8c63da) Signed-off-by: Adrian Gielniewski <adrian.gielniewski@nordicsemi.no>
adigie
force-pushed
the
fromtree-v1.4-branch
branch
3 times, most recently
from
b31c8bc to
c78f093
Compare
LuDuda
approved these changes
Mar 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick changes from v1.4 branch, up to 5fd234d4f14e1225533eaea85854f160bbd0fd55.