[nrf noup] boards: thingy91x: enable serial recovery #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxd-nordic
force-pushed
the
t91x_serial_recovery
branch
from
cb22d3f to
8596418
Compare
maxd-nordic
force-pushed
the
t91x_serial_recovery
branch
from
8596418 to
cbe99f3
Compare
maxd-nordic
force-pushed
the
t91x_serial_recovery
branch
from
cbe99f3 to
89175fa
Compare
nvlsianpu
reviewed
Apr 29, 2024
| CONFIG_BOOT_SERIAL_IMG_GRP_IMAGE_STATE=y | ||
|
|
||
| # Skip checks on the secondary image to make it possible to update MCUBoot on S1/S0 | ||
| CONFIG_MCUBOOT_VERIFY_IMG_ADDRESS=n |
There was a problem hiding this comment.
Are you sure wit that line?
Isn't that served by https://github.com/nrfconnect/sdk-mcuboot/blob/main/boot/bootutil/src/loader.c#L879-L881?
There was a problem hiding this comment.
I guess you know what you are doing.
There was a problem hiding this comment.
Yes, we needed to disable the checks there, otherwise the bootloader update would be rejected for not being a netcore update.
maxd-nordic
force-pushed
the
t91x_serial_recovery
branch
3 times, most recently
from
6cf1d69 to
b583547
Compare
nvlsianpu
approved these changes
May 7, 2024
This patch disbales MCUBoot logging and enables serial recovery for the Thingy:91. Signed-off-by: Maximilian Deubel <maximilian.deubel@nordicsemi.no> Signed-off-by: Bernt Johan Damslora <bernt.damslora@nordicsemi.no>
maxd-nordic
force-pushed
the
t91x_serial_recovery
branch
from
b583547 to
5c1feb3
Compare
sigvartmh
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch disbales MCUBoot logging and enables
serial recovery for the Thingy:91.