[nrf noup] boot/zephyr: nrf54h20dk support #408
Conversation
| CONFIG_SPI_NOR=n | ||
|
|
||
| # TODO: below are not yet supported and need fixing | ||
| CONFIG_FPROTECT=n |
There was a problem hiding this comment.
Should we add support for fprotect for nrf54h20 with new MCUBoot based approach ? If so, I will create a ticket
@nvlsianpu @tomchy
There was a problem hiding this comment.
As discussed, please create a ticket, so we can link it with a request for such feature in SDFW.
There was a problem hiding this comment.
| @@ -109,7 +113,10 @@ void nrf_cleanup_peripheral(void) | |||
| #if defined(NRF_DPPIC) | |||
| nrf_dppi_channels_disable_all(NRF_DPPIC); | |||
| #endif | |||
|
|
|||
| #if !defined(CONFIG_SOC_SERIES_NRF54HX) | |||
There was a problem hiding this comment.
Is it okay just to remove this clock cleanup on nrf54h20 ? Should these actions be performed in SDFW ? @tomchy @nvlsianpu
| @@ -62,10 +64,12 @@ static NRF_UARTE_Type *nrf_uarte_to_clean[] = { | |||
| }; | |||
| #endif | |||
|
|
|||
| #if !defined(CONFIG_SOC_SERIES_NRF54HX) | |||
| static void nrf_cleanup_clock(void) | |||
There was a problem hiding this comment.
Is there a Kconfig that indicates the availability of NRF_CLOCK API?
If so, it would be cleaner to use it here.
There was a problem hiding this comment.
I don't think there is such Kconfig available. This hal module was common for previous boards, we would need to introduce some new config. Should I do so ?
There was a problem hiding this comment.
Awaiting query on why device lacks flash controller, in additional PR should be split up, anything that can go upstream should go upstream and brought in via fromlist/fromtree, the conf can be as as new noup, the cleanup should be a separate commit with nrf squash! squashing onto the original noup for that file
| #elif (defined(CONFIG_SOC_SERIES_NRF54HX) && DT_HAS_CHOSEN(zephyr_flash)) | ||
|
|
||
| #define FLASH_DEVICE_ID SPI_FLASH_0_ID | ||
| #define FLASH_DEVICE_BASE CONFIG_FLASH_BASE_ADDRESS | ||
| #define FLASH_DEVICE_NODE DT_CHOSEN(zephyr_flash) |
There was a problem hiding this comment.
why is this needed, why is the flash controller not present in dts? change is OK, should be moved upstream
nordic-mik7
force-pushed
the
dev/lillium_mcuboot_support_push
branch
from
5d133e3 to
a30f7c5
Compare
Added basic adaptations eneeded for introducing nrf54h20dk board support in the future. Upstream PR #: 125 Signed-off-by: Michal Kozikowski <michal.kozikowski@nordicsemi.no> (cherry picked from commit b1b8d9de17171bb1f36dfc3c06bca6f95ba34a78)
Added basic support for nrf54h20dk_nrf54h20_cpuapp_iron board. This commit turns off CONFIG_FPROTECT for this board build. Signed-off-by: Michal Kozikowski <michal.kozikowski@nordicsemi.no>
This commit removes NRF_CLOCK cleanup for this board build - for Lillium, there is no clock peripheral access from the app domain. Signed-off-by: Michal Kozikowski <michal.kozikowski@nordicsemi.no>
nordic-mik7
force-pushed
the
dev/lillium_mcuboot_support_push
branch
from
a30f7c5 to
e38e2f6
Compare
|
|
Created separate clone pull request with requested changes #409 |
Added basic support for nrf54h20dk_nrf54h20_cpuapp_iron board. This commit turns off CONFIG_FPROTECT and excludes accessing hal nrf_clock.h interfaces from mcuboot for this board build.