nrf_security: kconfig: Dont enable TLS or X509 by default #14487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SebastianBoe
requested review from
frkv,
Vge0rge,
vlilleboe and
mswarowsky
as code owners
github-actions
bot
added
the
changelog-entry-required
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter' Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
mswarowsky
reviewed
Mar 12, 2024
SebastianBoe
force-pushed
the
more_reasonable_defaults
branch
from
6cb6766 to
4afd2f2
Compare
SebastianBoe
requested review from
krish2718,
jukkar,
rado17,
sachinthegreen and
rlubos
as code owners
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
SebastianBoe
force-pushed
the
more_reasonable_defaults
branch
from
4afd2f2 to
cc79797
Compare
|
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
SebastianBoe
force-pushed
the
more_reasonable_defaults
branch
from
cc79797 to
2d004a7
Compare
Vge0rge
approved these changes
Mar 14, 2024
krish2718
reviewed
Mar 14, 2024
SebastianBoe
force-pushed
the
more_reasonable_defaults
branch
from
2d004a7 to
ba2a21f
Compare
mswarowsky
approved these changes
Apr 11, 2024
update matter Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
It is bad practice for features to be enabled by default. It is not clear to me why these should be enabled when PSA and legacy ECD* are enabled. Enable PK_PARSE_C explicitly (used by hostap/src/crypto/crypto_mbedtls-ec.c) now that legacy is disabled by default. Signed-off-by: Sebastian Bøe <sebastian.boe@nordicsemi.no>
SebastianBoe
force-pushed
the
more_reasonable_defaults
branch
from
ba2a21f to
a2b23a8
Compare
|
I'm giving up on this. I expect this to change significantly soon anyway. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is bad practice for features to be enabled by default.
It is not clear to me why these should be enabled when PSA and legacy ECD* are enabled.