Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Improve Matter memory profiling. #14700

Merged

Conversation

ArekBalysNordic
Copy link
Contributor

Enabled NCS_SAMPLE_MATTER_SETTINGS_SHELL if CHIP_MEMORY_PROFILING is set.
Disabled SHELL_MINIMAL when the memory profiling is enabled.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 3, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 3, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@70be330 nrfconnect/sdk-connectedhomeip@f91ffce (master) nrfconnect/sdk-connectedhomeip@70be330c..f91ffce8

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 3, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add configuration to sample yamls based on the comment

@ArekBalysNordic ArekBalysNordic force-pushed the memory_profiling_improvements branch from 0a3bbf2 to f91b9b9 Compare April 4, 2024 08:01
@ArekBalysNordic ArekBalysNordic requested a review from a team as a code owner April 4, 2024 08:01
@ArekBalysNordic
Copy link
Contributor Author

Please add configuration to sample yamls based on the comment

@doublemis1 Done, please verify, especially the quarantine_integration.yaml file.

Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Enabled NCS_SAMPLE_MATTER_SETTINGS_SHELL if CHIP_MEMORY_PROFILING
is set.
Disabled SHELL_MINIMAL when the memory profiling is enabled.

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
@ArekBalysNordic ArekBalysNordic force-pushed the memory_profiling_improvements branch from f91b9b9 to 85564fb Compare April 4, 2024 09:36
@NordicBuilder NordicBuilder removed the DNM label Apr 4, 2024
@ArekBalysNordic ArekBalysNordic removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 4, 2024
@rlubos rlubos merged commit f5b591f into nrfconnect:main Apr 4, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants