Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Enable Partition Manager and DFU for nrf54l15. #14895

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

ArekBalysNordic
Copy link
Contributor

Added support for DFU and Partition Manger to nrf54l15 Matter samples for internal MRAM only. It means that the MCUBoot secondary partition is located in the internal MRAM memory. This configuration can be used in the release build type only.

  • Created pm_static.yaml with the partitioning map for internal MRAM memory only.
  • Enabled Partition Manager
  • Enabled DFU over BLE
  • Enabled DFU over Matter (OTA)

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Apr 16, 2024
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 17, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@d769c56 nrfconnect/sdk-connectedhomeip@053732b (master) nrfconnect/sdk-connectedhomeip@d769c56c..053732b6

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@ArekBalysNordic ArekBalysNordic marked this pull request as ready for review April 17, 2024 07:02
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 1f35330 to 0a360a3 Compare April 17, 2024 07:03
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Apr 17, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch 4 times, most recently from 7f62501 to 532f489 Compare April 17, 2024 13:52
@ArekBalysNordic ArekBalysNordic requested a review from a team as a code owner April 17, 2024 13:52
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 532f489 to bb94f50 Compare April 17, 2024 13:59
Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please move scenarios in integration quarantine to existing record for nrf54l15 platform for matter

@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from bb94f50 to 0861ced Compare April 17, 2024 14:03
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 0861ced to f40269f Compare April 19, 2024 14:22
@shanthanordic shanthanordic removed the request for review from a team April 22, 2024 06:29
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 2a6fdd3 to 43b082e Compare April 22, 2024 07:07
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 43b082e to f5e7a92 Compare April 22, 2024 07:56
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 22, 2024
@ArekBalysNordic ArekBalysNordic added this to the 2.6.99-dev1 milestone Apr 22, 2024
@doublemis1
Copy link
Contributor

All samples have configs *release.conf, while the template has *release_internal.conf.
Is it expected?

Copy link
Contributor

@doublemis1 doublemis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are the configs are properly set?

@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from f5e7a92 to 7e7faab Compare April 22, 2024 08:14
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 7e7faab to 02beb10 Compare April 22, 2024 09:02
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from 02beb10 to e946eb0 Compare April 22, 2024 09:14
Added support for DFU and Partition Manger to nrf54l15 Matter
samples for internal MRAM only. It means that the MCUBoot
secondary partition is located in the internal MRAM memory.
This configuration can be used in the release build type only.

- Created pm_static.yaml with the partitioning map for internal
MRAM memory only.
- Enabled Partition Manager
- Enabled DFU over BLE
- Enabled DFU over Matter (OTA)

Signed-off-by: Arkadiusz Balys <arkadiusz.balys@nordicsemi.no>
@ArekBalysNordic ArekBalysNordic force-pushed the nrf54l15_partition_manager branch from e946eb0 to 4357d79 Compare April 22, 2024 10:38
@NordicBuilder NordicBuilder removed the DNM label Apr 22, 2024
Copy link
Contributor

@markaj-nordic markaj-nordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LuDuda LuDuda merged commit e02f214 into nrfconnect:main Apr 22, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-required PR must not be merged without tech writer approval. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants