Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Fix sysbuild failures #15519

Merged
merged 5 commits into from
May 29, 2024
Merged

Conversation

krish2718
Copy link
Contributor

No description provided.

@krish2718 krish2718 requested review from krga2022 and lave30 May 27, 2024 12:54
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label May 27, 2024
@krish2718 krish2718 removed the request for review from chiranjeevi2776 May 27, 2024 13:03
@NordicBuilder
Copy link
Contributor

NordicBuilder commented May 27, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X
test-sdk-wifi X

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@krish2718 krish2718 requested a review from ajayparida May 27, 2024 17:01
Copy link
Contributor

@ajayparida ajayparida left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Prior to these changes, AP mode was not getting enabled.
With these patches able to start AP mode.

@sachinthegreen sachinthegreen added this to the 2.7.0 milestone May 28, 2024
krish2718 added 5 commits May 28, 2024 21:27
This was already selected by the driver.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
* No newline needed after "if"
* Add newline after a new section

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
The raw modes shouldn't be enabled by default, this was causing issues
with AP mode configuration.

Fixes SHEL-2781.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This callback is applicable for all modes.

Fixes SHEL-2781.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
For monitor mode we need to use the RAW modes patch, so, enable the RAW
modes config.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718 krish2718 force-pushed the fix_sysbuild_failures branch from b5d013f to 75b0d16 Compare May 28, 2024 15:59
@rlubos rlubos merged commit bd95d06 into nrfconnect:main May 29, 2024
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants