-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: matter: Use the generic ConnectivityManager methods #16559
samples: matter: Use the generic ConnectivityManager methods #16559
Conversation
The following west manifest projects have been modified in this Pull Request:
Note: This message is automatically posted and updated by the Manifest GitHub Action. |
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publishing GitHub Action. |
43ef799
to
bc0be56
Compare
Test specificationCI/Jenkins/NRF
CI/Jenkins/integration
test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter' Detailed information of selected test modules Note: This message is automatically posted and updated by the CI |
0620fa2
to
12d8e3f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, left one comment to consider
Limit the amount of ifdefs by utilizing the L2 agnostic network state checkers from Matter ConnectivityManager and replacing kDnssdInitialized event with kServerReady generic one. Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
12d8e3f
to
74a6bd7
Compare
Limit the amount of ifdefs by utilizing the L2 agnostic network
state checkers from Matter ConnectivityManager and replacing
kDnssdInitialized event with kServerReady generic one.