Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: matter: Use the generic ConnectivityManager methods #16559

Merged
merged 1 commit into from
Jul 24, 2024

Conversation

markaj-nordic
Copy link
Contributor

@markaj-nordic markaj-nordic commented Jul 22, 2024

Limit the amount of ifdefs by utilizing the L2 agnostic network
state checkers from Matter ConnectivityManager and replacing
kDnssdInitialized event with kServerReady generic one.

@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jul 22, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 22, 2024

The following west manifest projects have been modified in this Pull Request:

Name Old Revision New Revision Diff
matter nrfconnect/sdk-connectedhomeip@0ada603 nrfconnect/sdk-connectedhomeip@1f60b21 (master) nrfconnect/sdk-connectedhomeip@0ada603e..1f60b210

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

@markaj-nordic markaj-nordic force-pushed the matter_l2_agnostic_api branch 2 times, most recently from 43ef799 to bc0be56 Compare July 23, 2024 10:18
@markaj-nordic markaj-nordic marked this pull request as ready for review July 23, 2024 10:19
@markaj-nordic markaj-nordic requested review from a team, carlescufi and tejlmand as code owners July 23, 2024 10:19
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jul 23, 2024

Test specification

CI/Jenkins/NRF

  • Integration Platforms

CI/Jenkins/integration

Test Module File based changes Manually selected West overwrite
test-fw-nrfconnect-chip X

test-fw-nrfconnect-chip: added because there was no .github/test-spec.yml in 'matter'

Detailed information of selected test modules

Note: This message is automatically posted and updated by the CI

@markaj-nordic markaj-nordic force-pushed the matter_l2_agnostic_api branch 2 times, most recently from 0620fa2 to 12d8e3f Compare July 23, 2024 11:23
Copy link
Contributor

@kkasperczyk-no kkasperczyk-no left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, left one comment to consider

Limit the amount of ifdefs by utilizing the L2 agnostic network
state checkers from Matter ConnectivityManager and replacing
kDnssdInitialized event with kServerReady generic one.

Signed-off-by: Marcin Kajor <marcin.kajor@nordicsemi.no>
@markaj-nordic markaj-nordic force-pushed the matter_l2_agnostic_api branch from 12d8e3f to 74a6bd7 Compare July 24, 2024 07:13
@NordicBuilder NordicBuilder removed the DNM label Jul 24, 2024
@nordicjm nordicjm merged commit 09034ca into nrfconnect:main Jul 24, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-matter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants