Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: nrf_modem_lib: Turn off CONFIG_COAP_CLIENT_TRUNCATE_MSGS #17587

Merged

Conversation

plskeggs
Copy link
Contributor

@plskeggs plskeggs commented Oct 1, 2024

This is to prepare for eventual upmerge of zephyrproject-rtos/zephyr#79155. An earlier version of that is included in the pre-NCS 2.8.0 upmerge already, but that earlier version had the new Kconfig defaulting to n.

This upstream Zephyr PR will default it to y, but is not compatible with the modem's socket implementation, so turn it off here.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Oct 1, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 13

Inputs:

Sources:

sdk-nrf: PR head: eda34ccdd04e97c579ba0604be672f24a1ac8d34

more details

sdk-nrf:

PR head: eda34ccdd04e97c579ba0604be672f24a1ac8d34
merge base: 4bad1c2b3a6cb176f56ada5575e7e48785e7b9da
target head (main): 7f59f243414254a4b2556c60610b8327ee4d8603
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
lib
│  ├── nrf_modem_lib
│  │  │ Kconfig.modemlib

Outputs:

Toolchain

Version: 6c44240e03
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:6c44240e03_81ed5a52d6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 12
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

Copy link
Contributor

@trantanen trantanen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commit and PR title should say lib: nrf_modem_lib though.

@plskeggs plskeggs force-pushed the coap-client-turn-off-msg-truncate-flag branch from 0a20363 to 205ff15 Compare October 3, 2024 17:55
@plskeggs plskeggs changed the title lib: nrf_modem: Turn off CONFIG_COAP_CLIENT_TRUNCATE_MSGS lib: nrf_modem_lib: Turn off CONFIG_COAP_CLIENT_TRUNCATE_MSGS Oct 3, 2024
@plskeggs plskeggs removed DNM changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Oct 3, 2024
@plskeggs plskeggs marked this pull request as ready for review October 3, 2024 17:57
@plskeggs plskeggs force-pushed the coap-client-turn-off-msg-truncate-flag branch from 205ff15 to 3000bf9 Compare October 3, 2024 23:41
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 3, 2024
@plskeggs plskeggs force-pushed the coap-client-turn-off-msg-truncate-flag branch from 3000bf9 to 72c1ec5 Compare October 4, 2024 17:33
This upstream Kconfig defaults to y, but is not compatible
with the modem's socket implementation.

Signed-off-by: Pete Skeggs <peter.skeggs@nordicsemi.no>
@plskeggs plskeggs force-pushed the coap-client-turn-off-msg-truncate-flag branch from 72c1ec5 to eda34cc Compare October 7, 2024 21:27
@plskeggs plskeggs added this to the 2.8.0 milestone Oct 9, 2024
@rlubos rlubos merged commit 399bb73 into nrfconnect:main Oct 9, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants