Followup on PR-17502 #17941

rghaddab · 2024-10-16T14:43:50Z

This PR fixes some comments raised in this merged PR:
#17502

NordicBuilder · 2024-10-16T14:50:54Z

The following west manifest projects have been modified in this Pull Request:

Name	Old Revision	New Revision	Diff
matter	nrfconnect/sdk-connectedhomeip@`731aac5`	nrfconnect/sdk-connectedhomeip@`5148b72` (master)	nrfconnect/sdk-connectedhomeip@731aac5c..5148b72b

Note: This message is automatically posted and updated by the Manifest GitHub Action.

ArekBalysNordic

Thanks!

NordicBuilder · 2024-10-16T14:58:01Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 8

Inputs:

Sources:

sdk-nrf: PR head: 4529cf6085f3fd3a988914f1bcdfedaf3c4a97b8
matter: PR head: 5148b72bda4773ccaaf7df52149f765f01248079

more details

sdk-nrf:

PR head: 4529cf6085f3fd3a988914f1bcdfedaf3c4a97b8
merge base: 8a536ebde8bdc0c780ee149d5ffb1dcf1dc9581c
target head (main): c673d2b5c544d59260a08a8b4531017c11dcd0a2
Diff

matter:

PR head: 5148b72bda4773ccaaf7df52149f765f01248079
merge base: 731aac5c8941bf0f0a9f10c759f533e5b01f80eb
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (7)

modules
│  ├── lib
│  │  ├── matter
│  │  │  ├── src
│  │  │  │  ├── platform
│  │  │  │  │  ├── Zephyr
│  │  │  │  │  │  │ ConfigurationManagerImpl.cpp
samples
│  ├── bluetooth
│  │  ├── central_and_peripheral_hr
│  │  │  ├── Kconfig
│  │  │  │ prj.conf
│  │  ├── peripheral_hids_mouse
│  │  │  │ Kconfig
│  ├── matter
│  │  ├── common
│  │  │  ├── src
│  │  │  │  ├── persistent_storage
│  │  │  │  │  │ persistent_storage_shell.cpp
subsys
│  ├── partition_manager
│  │  │ pm.yml.zms
west.yml

Outputs:

Toolchain

Version: 3dd8985b56
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:3dd8985b56_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 7
✅ Integration tests
- ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
- ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_cloud - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_libmodem-nrf - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
- ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-fw-nrfconnect-nrf-iot_nrf_provisioning - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
- ✅ test-sdk-dfu
- ✅ test-fw-nrfconnect-ps
- ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run
- ⚠️ test-fw-nrfconnect-fw-update

Note: This message is automatically posted and updated by the CI

NordicBuilder · 2024-10-16T15:06:05Z

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publishing GitHub Action.

rghaddab · 2024-10-21T11:59:08Z

@nordicjm @tejlmand can you approve this PR ?

tomi-font · 2024-10-21T12:00:58Z

@rghaddab You're not meant to touch the DNM label that was set by the bot. It's removed automatically when the manifest file doesn't point to a PR anymore.

rghaddab · 2024-10-21T12:07:44Z

@rghaddab You're not meant to touch the DNM label that was set by the bot. It's removed automatically when the manifest file doesn't point to a PR anymore.

You are right, I forgot that this PR has a change in the manifest file.
Let's wait until this PR gets merged : nrfconnect/sdk-connectedhomeip#496

Remove this unneeded config and fix some style issues Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

Using defined() macro allows in the future adding boolean expressions Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

Current configuration doesn't take into account the cases where we use external flash. Fix this by changing "select" to "imply" Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

rghaddab · 2024-10-22T11:22:00Z

@maje-emb @ppryga-nordic can you approve this PR on behalf of muffin and dragoon teams ?

rghaddab · 2024-10-23T09:22:00Z

@nrfconnect/ncs-si-muffin @nrfconnect/ncs-dragoon can I get some help to merge this PR ?

hermabe

Again, dragoon doesnt own these samples, but LGTM

rghaddab requested review from a team, nordicjm and tejlmand as code owners October 16, 2024 14:43

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Oct 16, 2024

rghaddab force-pushed the rghaddab/pr-zms-style-fixup branch from 697df45 to 4afc7fd Compare October 16, 2024 14:50

rghaddab requested a review from a team as a code owner October 16, 2024 14:50

github-actions bot added the manifest label Oct 16, 2024

NordicBuilder added manifest-matter DNM labels Oct 16, 2024

ArekBalysNordic approved these changes Oct 16, 2024

View reviewed changes

rghaddab removed the DNM label Oct 17, 2024

rghaddab force-pushed the rghaddab/pr-zms-style-fixup branch from 4afc7fd to b1d8061 Compare October 17, 2024 15:55

NordicBuilder added the DNM label Oct 17, 2024

rghaddab force-pushed the rghaddab/pr-zms-style-fixup branch from b1d8061 to 3334c70 Compare October 18, 2024 07:59

rghaddab removed the DNM label Oct 21, 2024

tomi-font added the DNM label Oct 21, 2024

nordicjm approved these changes Oct 21, 2024

View reviewed changes

rghaddab added 3 commits October 21, 2024 16:42

partition_manager: zms: remove NRF54L15_ENGA config

fe6b5dd

Remove this unneeded config and fix some style issues Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

matter: persistent_storage: use defined() macro instead of #ifdef

984f320

Using defined() macro allows in the future adding boolean expressions Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

samples: bluetooth: change Kconfig for ZMS and NVS

4529cf6

Current configuration doesn't take into account the cases where we use external flash. Fix this by changing "select" to "imply" Signed-off-by: Riadh Ghaddab <rghaddab@baylibre.com>

rghaddab force-pushed the rghaddab/pr-zms-style-fixup branch from 3334c70 to 4529cf6 Compare October 21, 2024 14:44

NordicBuilder removed the DNM label Oct 21, 2024

ArekBalysNordic added this to the 2.8.0 milestone Oct 23, 2024

hermabe approved these changes Oct 23, 2024

View reviewed changes

dchat-nordic approved these changes Oct 23, 2024

View reviewed changes

rlubos merged commit 5495fab into nrfconnect:main Oct 23, 2024
13 of 14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Followup on PR-17502 #17941

Followup on PR-17502 #17941

rghaddab commented Oct 16, 2024

NordicBuilder commented Oct 16, 2024 •

edited

Loading

ArekBalysNordic left a comment

NordicBuilder commented Oct 16, 2024 •

edited

Loading

NordicBuilder commented Oct 16, 2024

rghaddab commented Oct 21, 2024

tomi-font commented Oct 21, 2024

rghaddab commented Oct 21, 2024

rghaddab commented Oct 22, 2024

rghaddab commented Oct 23, 2024

hermabe left a comment

Followup on PR-17502 #17941

Followup on PR-17502 #17941

Conversation

rghaddab commented Oct 16, 2024

NordicBuilder commented Oct 16, 2024 • edited Loading

ArekBalysNordic left a comment

Choose a reason for hiding this comment

NordicBuilder commented Oct 16, 2024 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

NordicBuilder commented Oct 16, 2024

rghaddab commented Oct 21, 2024

tomi-font commented Oct 21, 2024

rghaddab commented Oct 21, 2024

rghaddab commented Oct 22, 2024

rghaddab commented Oct 23, 2024

hermabe left a comment

Choose a reason for hiding this comment

NordicBuilder commented Oct 16, 2024 •

edited

Loading

NordicBuilder commented Oct 16, 2024 •

edited

Loading