-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cmake: remove NCS Toolchain CMake package lookup #19225
cmake: remove NCS Toolchain CMake package lookup #19225
Conversation
Jira: NCSDK-30518 nrfutil provides a custom command / shell environment which defines all required tools. VSCode uses this environment and therefore doesn't rely on the NCS Toolchain CMake package. To simplify NCS Toolchain integration then this PR removes the NCS CMake package lookup. The integration has also at some point become broken, which results in the following error when trying to build outside the environment provided by nrfutil: > Could NOT find Python3 (missing: Interpreter) (Required is at least > version "3.10") > > Reason given by package: > Interpreter: Cannot run the interpreter > "/.../toolchains/b81a7cd864/usr/local/bin/python3" Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 72287f242cf1168408d355ae3ad9ae8d046e4e58 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
how can we test that this fixes the issue with vscode? |
Remove |
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fixes the issue in https://nordicsemi.atlassian.net/browse/NCSIDB-1429
Jira: NCSDK-30518
nrfutil provides a custom command / shell environment which defines all required tools.
VSCode uses this environment and therefore doesn't rely on the NCS Toolchain CMake package.
To simplify NCS Toolchain integration then this PR removes the NCS CMake package lookup.
The integration has also at some point become broken, which results in the following error when trying to build outside the environment provided by nrfutil: