Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake: remove NCS Toolchain CMake package lookup #19225

Merged

Conversation

tejlmand
Copy link
Contributor

@tejlmand tejlmand commented Dec 3, 2024

Jira: NCSDK-30518

nrfutil provides a custom command / shell environment which defines all required tools.

VSCode uses this environment and therefore doesn't rely on the NCS Toolchain CMake package.

To simplify NCS Toolchain integration then this PR removes the NCS CMake package lookup.

The integration has also at some point become broken, which results in the following error when trying to build outside the environment provided by nrfutil:

Could NOT find Python3 (missing: Interpreter) (Required is at least
version "3.10")

 Reason given by package:
     Interpreter: Cannot run the interpreter
     "/.../toolchains/b81a7cd864/usr/local/bin/python3"

Jira: NCSDK-30518

nrfutil provides a custom command / shell environment which defines
all required tools.

VSCode uses this environment and therefore doesn't rely on the
NCS Toolchain CMake package.

To simplify NCS Toolchain integration then this PR removes the NCS CMake
package lookup.

The integration has also at some point become broken, which results in
the following error when trying to build outside the environment
provided by nrfutil:
> Could NOT find Python3 (missing: Interpreter) (Required is at least
> version "3.10")
>
>      Reason given by package:
>          Interpreter: Cannot run the interpreter
>          "/.../toolchains/b81a7cd864/usr/local/bin/python3"

Signed-off-by: Torsten Rasmussen <Torsten.Rasmussen@nordicsemi.no>
@tejlmand tejlmand requested review from a team as code owners December 3, 2024 15:05
@tejlmand tejlmand requested a review from bencefr December 3, 2024 15:05
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 3, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 72287f242cf1168408d355ae3ad9ae8d046e4e58

more details

sdk-nrf:

PR head: 72287f242cf1168408d355ae3ad9ae8d046e4e58
merge base: 09228a59365ab09daab2c6050044d6c9cf065ea1
target head (main): 09228a59365ab09daab2c6050044d6c9cf065ea1
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
CODEOWNERS
scripts
│  │ ncs-toolchain-version-minimum.txt
share
│  ├── ncs-package
│  │  ├── cmake
│  │  │  │ NcsConfig.cmake

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 44
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@thst-nordic
Copy link
Contributor

thst-nordic commented Dec 3, 2024

how can we test that this fixes the issue with vscode?

@tejlmand
Copy link
Contributor Author

tejlmand commented Dec 3, 2024

how can we test that this fixes the issue with vscode?

Remove -DNCS_TOOCHAIN_VERSION=NONE from VSCode build launch and try building anything with this PR.
@kylebonnici can you try that ?

Copy link

github-actions bot commented Jan 3, 2025

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

@github-actions github-actions bot added the Stale label Jan 3, 2025
@tejlmand tejlmand removed the Stale label Jan 7, 2025
@tejlmand tejlmand requested a review from kylebonnici January 7, 2025 14:48
Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@carlescufi carlescufi merged commit 9299b43 into nrfconnect:main Jan 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants