Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wifi: Fix scan sample build #19709

Merged
merged 2 commits into from
Jan 9, 2025
Merged

Conversation

krish2718
Copy link
Contributor

scan sample build fix and improve configuration parsing.

@krish2718 krish2718 requested a review from divyagona December 26, 2024 15:12
@krish2718 krish2718 requested review from a team, D-Triveni and bama-nordic as code owners December 26, 2024 15:12
@krish2718 krish2718 changed the title Fix scan sample wifi: Fix scan sample build Dec 26, 2024
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Dec 26, 2024
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Dec 26, 2024

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 3e2a902594f35c2a183e35f3cb1acc6590a21e3b

more details

sdk-nrf:

PR head: 3e2a902594f35c2a183e35f3cb1acc6590a21e3b
merge base: cac49ac985664e9357e1c30691ce1091470c528b
target head (main): cac49ac985664e9357e1c30691ce1091470c528b
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3)
samples
│  ├── wifi
│  │  ├── scan
│  │  │  ├── Kconfig
│  │  │  ├── overlay-shell.conf
│  │  │  ├── src
│  │  │  │  │ main.c

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 161
  • ✅ Integration tests
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_nrf_provisioning
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@krish2718 krish2718 force-pushed the fix_scan_sample branch 2 times, most recently from 5b387ae to d02e008 Compare December 26, 2024 15:25
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@krish2718 krish2718 requested a review from nordicjm January 2, 2025 12:25
When options that set the channel are enabled, non-existent member
"chan" is used instead of "band_chan" causing build error.

Rejig the options to simplify the scan configuration processing that
also fixes the build error.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
This is handy for debugging, primarily for kernel heap tracking.

Signed-off-by: Chaitanya Tata <Chaitanya.Tata@nordicsemi.no>
@krish2718
Copy link
Contributor Author

Ping @nordicjm

@nordicjm nordicjm merged commit 7084bd6 into nrfconnect:main Jan 9, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants