-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc: Refer test commands section of BLE Core Spec in DTM sample #19775
doc: Refer test commands section of BLE Core Spec in DTM sample #19775
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:more detailsGithub labels
List of changed files detected by CI (0)
Outputs:ToolchainVersion: Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
ac009f0
to
0d1e4f2
Compare
0d1e4f2
to
83f3ad4
Compare
83f3ad4
to
bdbce3c
Compare
@@ -8,6 +8,8 @@ Bluetooth: Direct Test Mode | |||
:depth: 2 | |||
|
|||
This sample enables the Direct Test Mode functions described in `Bluetooth® Core Specification <Bluetooth Core Specification_>`_ (Vol. 6, Part F). | |||
The actual encoding of the test commands and events are described in Vol. 6, Part F, section 3.3 of this specification document. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a question: Is it encoding of test commands and encoding of events? If yes, then ... is described.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As per my understanding its encoded test commands and events. @grochu : Please confirm.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I looked directly to the spec. The section 3.3 name is "Commands and events" but it describes the encoding of commands only. The actual bit encoding of events is described in the next section: 3.4. So I'd mention both sections here. Since we want to be very clear to the customers, I'd be specific that 3.3 is for commands and 3.4 for events and there should be no doubt.
bdbce3c
to
d737160
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good
Refer actual encoding of the test commands and events section of BLE Core Spec in Direct test mode sample. Signed-off-by: divya pillai <divya.pillai@nordicsemi.no>
d737160
to
1974ff5
Compare
Refer actual encoding of the test commands and events section of BLE Core Spec in Direct test mode sample.
TECHDOC-3198