Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: Refer test commands section of BLE Core Spec in DTM sample #19775

Merged
merged 1 commit into from
Jan 13, 2025

Conversation

divipillai
Copy link
Contributor

@divipillai divipillai commented Jan 7, 2025

Refer actual encoding of the test commands and events section of BLE Core Spec in Direct test mode sample.

TECHDOC-3198

@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Jan 7, 2025
@divipillai divipillai added the CI-disable Disable CI for this PR label Jan 7, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 7, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link. It will be updated about 10 minutes after the documentation build succeeds.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@divipillai divipillai force-pushed the TECHDOC-3198_direct_test_modes branch from ac009f0 to 0d1e4f2 Compare January 8, 2025 11:48
@divipillai divipillai requested a review from grochu January 8, 2025 11:48
@divipillai divipillai marked this pull request as ready for review January 8, 2025 11:48
@divipillai divipillai requested a review from a team as a code owner January 8, 2025 11:48
@divipillai divipillai force-pushed the TECHDOC-3198_direct_test_modes branch from 0d1e4f2 to 83f3ad4 Compare January 8, 2025 11:52
@divipillai divipillai changed the title doc: Refer test commands section of BLE Core Spec in Direct test mode… Refer test commands section of BLE Core Spec in DTM sample Jan 8, 2025
@divipillai divipillai changed the title Refer test commands section of BLE Core Spec in DTM sample doc: Refer test commands section of BLE Core Spec in DTM sample Jan 8, 2025
@divipillai divipillai force-pushed the TECHDOC-3198_direct_test_modes branch from 83f3ad4 to bdbce3c Compare January 8, 2025 14:04
@divipillai divipillai requested a review from peknis January 8, 2025 14:05
@@ -8,6 +8,8 @@ Bluetooth: Direct Test Mode
:depth: 2

This sample enables the Direct Test Mode functions described in `Bluetooth® Core Specification <Bluetooth Core Specification_>`_ (Vol. 6, Part F).
The actual encoding of the test commands and events are described in Vol. 6, Part F, section 3.3 of this specification document.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a question: Is it encoding of test commands and encoding of events? If yes, then ... is described.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As per my understanding its encoded test commands and events. @grochu : Please confirm.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked directly to the spec. The section 3.3 name is "Commands and events" but it describes the encoding of commands only. The actual bit encoding of events is described in the next section: 3.4. So I'd mention both sections here. Since we want to be very clear to the customers, I'd be specific that 3.3 is for commands and 3.4 for events and there should be no doubt.

@divipillai divipillai force-pushed the TECHDOC-3198_direct_test_modes branch from bdbce3c to d737160 Compare January 10, 2025 13:59
@divipillai divipillai requested a review from peknis January 10, 2025 14:00
Copy link
Contributor

@grochu grochu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

Refer actual encoding of the test commands and events section
of BLE Core Spec in Direct test mode sample.

Signed-off-by: divya pillai <divya.pillai@nordicsemi.no>
@divipillai divipillai force-pushed the TECHDOC-3198_direct_test_modes branch from d737160 to 1974ff5 Compare January 13, 2025 11:29
@divipillai divipillai requested a review from peknis January 13, 2025 11:29
@nordicjm nordicjm merged commit 3ba3fb3 into nrfconnect:main Jan 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants