Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: Replace ecdsa library with cryptography #19788

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

fundakol
Copy link
Contributor

@fundakol fundakol commented Jan 8, 2025

Simplify python scripts by removing ecdsa library and rewriting code with cryptography library,
which provides same functionality.

@fundakol fundakol requested a review from gchwier January 8, 2025 10:26
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 8, 2025
@fundakol fundakol marked this pull request as ready for review January 8, 2025 10:26
@fundakol fundakol requested review from a team as code owners January 8, 2025 10:26
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 8, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 13

Inputs:

Sources:

sdk-nrf: PR head: 6c66bbac4d8df2e18885a374ed9590a2722dc406

more details

sdk-nrf:

PR head: 6c66bbac4d8df2e18885a374ed9590a2722dc406
merge base: 00b6cd8b5fbaf671b0739a813cc8cc5a887ad8ba
target head (main): 00b6cd8b5fbaf671b0739a813cc8cc5a887ad8ba
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (10)
scripts
│  ├── bootloader
│  │  ├── do_sign.py
│  │  ├── keygen.py
│  │  ├── provision.py
│  │  ├── tests
│  │  │  ├── conftest.py
│  │  │  ├── do_sign_test.py
│  │  │  ├── keygen_test.py
│  │  │  ├── utils.py
│  │  │  │ validation_data_test.py
│  │  │ validation_data.py
│  │ requirements-test.txt

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_bbe5b33786

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 26
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-boot
    • ✅ test-sdk-mcuboot
    • ⚠️ test-fw-nrfconnect-fw-update
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@fundakol fundakol force-pushed the refactor-bootloader-scripts branch 5 times, most recently from 242f6b7 to 6faac43 Compare January 13, 2025 15:05
Copy link
Contributor

@nvlsianpu nvlsianpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just to Fix CI?

@fundakol
Copy link
Contributor Author

Just to Fix CI?
Yes, there are some tests with openssl which fail with the refactored scripts. I need to fix it.

@fundakol fundakol force-pushed the refactor-bootloader-scripts branch 4 times, most recently from aa258f1 to b99af57 Compare January 30, 2025 17:17
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber stamping without checking changes

Simplify python scripts by removing ecdsa library and
rewriting code with cryptography library,
which provides same functionality.

Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
@fundakol fundakol force-pushed the refactor-bootloader-scripts branch from b99af57 to 6c66bba Compare February 11, 2025 10:32
@nvlsianpu nvlsianpu merged commit 71e9e16 into nrfconnect:main Feb 11, 2025
17 checks passed
@fundakol fundakol deleted the refactor-bootloader-scripts branch February 11, 2025 12:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants