-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bluetooth: Mesh: fix uptime to tai conversion inaccuracy #19805
Conversation
Commit fixes uptime to tai inaccuracy conversion. Previous implementation did not take into account subseconds overflow that caused -1 second inaccuracy. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: b3ec7396fdf1957ffe8ef59d9e7fc58cc6c47afe more detailssdk-nrf:
Github labels
List of changed files detected by CI (1)
Outputs:ToolchainVersion: b77d8c1312 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
I'm pretty sure it will not be merged until somebody review from @nrfconnect/ncs-paladin according to current rules. It does not require additional DNM label. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks correct. Original code was dependent on compiler specific behavior, so this is better.
Commit fixes uptime to tai inaccuracy conversion.
Previous implementation did not take into account
subseconds overflow that caused -1 second inaccuracy.