-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bluetooth: Use K_MEM_SLAB_DEFINE_STATIC in BT_CONN_CTX_DEF #19855
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good change, but please fix the mentioned whitechars used for alignment.
include/bluetooth/conn_ctx.h
Outdated
ROUND_UP(_ctx_sz, CONFIG_BT_CONN_CTX_MEM_BUF_ALIGN), \ | ||
(_max_clients), \ | ||
CONFIG_BT_CONN_CTX_MEM_BUF_ALIGN); \ | ||
K_MUTEX_DEFINE(_name##_mutex); \ | ||
static K_MUTEX_DEFINE(_name##_mutex); \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that spaces were changed to tabs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, didn't mean to do that. Fixed, thanks!
Use K_MEM_SLAB_DEFINE_STATIC in BT_CONN_CTX_DEF to avoid polluting global namespace so that multiple BT_HIDS_DEF() with the same name in different files won't conflict with each other. Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
f4a036d
to
1f20665
Compare
This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time. |
Use K_MEM_SLAB_DEFINE_STATIC in BT_CONN_CTX_DEF to avoid polluting global namespace so that multiple BT_HIDS_DEF() with the same name in different files won't conflict with each other.