Bluetooth: gatt_pool: Supress -Waddress in EL_IN_POOL_VERIFY

[ndreys]

GCC13 will complain here with:

gatt_pool.c:165:69: warning: the comparison will always evaluate as 'true' for the address of 'chrc_tab' will never be NULL [-Waddress]

when CONFIG_ASSERT is set. Since the problem is harmless add warning supression pragmas to avoid build failures with -Werror.

[NordicBuilder]

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

[pdunaj]

This is source file and pools are defined buildtime.
If this is a real problem it can be resolved by modifying the way the check is done.

[ndreys]

This is source file and pools are defined buildtime. If this is a real problem it can be resolved by modifying the way the check is done.

From reading the code E_IN_POOL_VERIFY is either used with a static array pointer or NULL, so I think the other way to deal with this would be to drop the != NULL check altogether since it does seem particularly valuable. Something like:

modified   subsys/bluetooth/gatt_pool.c
@@ -79,7 +79,6 @@ static struct bt_uuid const * const uuid_ccc = BT_UUID_GATT_CCC;
 
 #define EL_IN_POOL_VERIFY(pool, el)                                            \
 	do {                                                                   \
-		__ASSERT(pool != NULL, "Pool is uninitialized");               \
 		__ASSERT(((uint32_t)el >= (uint32_t)pool) &&                         \
 			     (((uint32_t)el) < (((uint32_t)pool) + sizeof(pool))),   \
 			 "Element does not belong to the pool");               \
@@ -163,8 +162,10 @@ static int chrc_get(struct bt_gatt_chrc **chrc)
 static void chrc_release(struct bt_gatt_chrc const *chrc)
 {
 	EL_IN_POOL_VERIFY(BT_GATT_CHRC_TAB, chrc);
+if CONFIG_BT_GATT_CHRC_POOL_SIZE != 0
 	atomic_clear_bit(chrc_pool.locks,
 			 ADDR_2_INDEX(BT_GATT_CHRC_TAB, chrc));
+#endif
 }

Thoughts? I'm low on any other ideas, but I'm open to suggestions.

[github-actions]

This pull request has been marked as stale because it has been open (more than) 30 days with no activity. Remove the stale label or add a comment saying that you would like to have the label removed otherwise this pull request will automatically be closed in 7 days. Note, that you can always re-open a closed pull request at any time.

[ndreys]

Can someone from Nordic please take a look at this? I don't think any actions were required of me to make any progress here