tests: drivers: Add test for SDP ASM #19857

nordic-segl · 2025-01-13T06:58:18Z

Add test that confirms operation of Software Defined Peripherals Assembly Management.

NordicBuilder · 2025-01-13T06:59:39Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 5

Inputs:

Sources:

sdk-nrf: PR head: 103f5d1ca8c948ac87bb5841c5a7001ed50939e2

more details

sdk-nrf:

PR head: 103f5d1ca8c948ac87bb5841c5a7001ed50939e2
merge base: 658662845a8e4d4cb677800c8d36acfac9176c90
target head (main): 7f1e6c6122bf650942f8c2201185c583c77a2ce9
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (15)

CODEOWNERS
tests
│  ├── drivers
│  │  ├── sdp_asm
│  │  │  ├── CMakeLists.txt
│  │  │  ├── prj.conf
│  │  │  ├── pytest
│  │  │  │  │ test_sdp_asm.py
│  │  │  ├── src
│  │  │  │  ├── add_1.c
│  │  │  │  ├── add_1.h
│  │  │  │  ├── add_1.s
│  │  │  │  ├── add_10.c
│  │  │  │  ├── add_10.h
│  │  │  │  ├── add_10.s
│  │  │  │  ├── add_100.c
│  │  │  │  ├── add_100.h
│  │  │  │  ├── add_100.s
│  │  │  │  │ main.c
│  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: b77d8c1312
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:b77d8c1312_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 56
✅ Integration tests

Disabled integration tests

- desktop52_verification
- doc-internal
- test_ble_nrf_config
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_nrf_provisioning
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

tests/drivers/sdp_asm/pytest/test_sdp_asm.py

Add test that confirms operation of Software Defined Peripherals Assembly Management. Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>

nordic-segl · 2025-01-14T13:53:44Z

tests/drivers/sdp_asm/CMakeLists.txt

+target_sources(app PRIVATE src/main.c)
+target_sources(app PRIVATE src/add_1.s)
+target_sources(app PRIVATE src/add_10.s)
+target_sources(app PRIVATE src/add_100.s)


Build shall link pre-compiled assembler files.

nordic-segl · 2025-01-14T13:54:39Z

tests/drivers/sdp_asm/pytest/test_sdp_asm.py

+    OUTPUT1 = """initial: 0, 0, 0
+after add_1: 1, 2, 3
+after add_10: 11, 22, 33
+after add_100: 111, 222, 333"""


This is expected output when pre-compiled assembler files are linked in the build.

nordic-segl · 2025-01-14T13:58:44Z

tests/drivers/sdp_asm/pytest/test_sdp_asm.py

+    OUTPUT2 = """initial: 0, 0, 0
+after add_1: 2, 3, 4
+after add_10: 12, 23, 34
+after add_100: 212, 323, 434"""


This is expected output when add_1(), add_10() and add_100() from C sources are linked in the build. For this to happen, user has to:

build sources (this will create add_1-temp.s, add_10-temp.s, add_100-temp.s file + warning that compilation of C sources resulted in a different assembly than existing *.s files)

call ninja asm_install (this will substitute *.s files in the src directory with recently built *-temp.s ones)

build sources again

nordic-segl · 2025-01-14T14:01:52Z

tests/drivers/sdp_asm/src/add_1.c

+extern volatile uint16_t arg_uint16_t;
+extern volatile uint32_t arg_uint32_t;
+
+void hrt_add_1(void)


C implementation of this function increases variables by +2, +3, +4

nordic-segl · 2025-01-14T14:02:13Z

tests/drivers/sdp_asm/src/add_1.s

+hrt_add_1:
+	lui	a4,%hi(arg_uint8_t)
+	lbu	a5,%lo(arg_uint8_t)(a4)
+	addi	a5,a5,1


ASM implementation of this function increases variables by +1, +2, +3

nordic-segl · 2025-01-14T14:02:37Z

tests/drivers/sdp_asm/src/add_10.c

+extern volatile uint16_t arg_uint16_t;
+extern volatile uint32_t arg_uint32_t;
+
+void hrt_add_10(void)


Same implementation in ASM and C.

nordic-segl · 2025-01-14T14:03:18Z

tests/drivers/sdp_asm/src/add_10.s

+hrt_add_10:
+	lui	a4,%hi(arg_uint8_t)
+	lbu	a5,%lo(arg_uint8_t)(a4)
+	addi	a5,a5,10


same as in C

nordic-segl · 2025-01-14T14:04:07Z

tests/drivers/sdp_asm/src/add_100.c

+extern volatile uint16_t arg_uint16_t;
+extern volatile uint32_t arg_uint32_t;
+
+void hrt_add_100(void)


C implementation of this function increases variables by +200, +300, +400

nordic-segl · 2025-01-14T14:04:22Z

tests/drivers/sdp_asm/src/add_100.s

+hrt_add_100:
+	lui	a4,%hi(arg_uint8_t)
+	lbu	a5,%lo(arg_uint8_t)(a4)
+	addi	a5,a5,100


ASM implementation of this function increases variables by +100, +200, +300

nordic-segl · 2025-01-14T14:05:28Z

tests/drivers/sdp_asm/src/main.c

+int main(void)
+{
+	printf("SDP ASM test on %s\n", CONFIG_BOARD_TARGET);
+	printf("initial: %u, %u, %u\n", arg_uint8_t, arg_uint16_t, arg_uint32_t);


initial: 0, 0, 0

nordic-segl · 2025-01-14T14:07:31Z

tests/drivers/sdp_asm/src/main.c

+	printf("SDP ASM test on %s\n", CONFIG_BOARD_TARGET);
+	printf("initial: %u, %u, %u\n", arg_uint8_t, arg_uint16_t, arg_uint32_t);
+	hrt_add_1();
+	printf("after add_1: %u, %u, %u\n", arg_uint8_t, arg_uint16_t, arg_uint32_t);


after add_1: 1, 2, 3 (if pre-compiled ASM are linked in) or
after add_1: 2, 3, 4 (after ninja asm_install)

nordic-segl · 2025-01-15T13:34:35Z

please review

nordic-segl requested review from a team as code owners January 13, 2025 06:58

github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 13, 2025

nordic-segl force-pushed the NRFX-6516_Add-test-for-SDP_ASM branch from 12d9bac to 9bc56bc Compare January 13, 2025 07:09

github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 13, 2025

nordic-segl requested review from masz-nordic, nordic-babu, nordic-piks, magp-nordic, nordic-pikr, nordic-bami and jaz1-nordic January 13, 2025 07:25

nordic-piks reviewed Jan 13, 2025

View reviewed changes

tests/drivers/sdp_asm/pytest/test_sdp_asm.py Outdated Show resolved Hide resolved

nordic-segl force-pushed the NRFX-6516_Add-test-for-SDP_ASM branch from 9bc56bc to afa6e04 Compare January 13, 2025 08:57

nordic-piks reviewed Jan 13, 2025

View reviewed changes

tests/drivers/sdp_asm/pytest/test_sdp_asm.py Outdated Show resolved Hide resolved

nordic-segl force-pushed the NRFX-6516_Add-test-for-SDP_ASM branch from afa6e04 to 42b8feb Compare January 13, 2025 09:20

nordic-piks approved these changes Jan 13, 2025

View reviewed changes

tests: drivers: Add test for SDP ASM

103f5d1

Add test that confirms operation of Software Defined Peripherals Assembly Management. Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>

nordic-segl force-pushed the NRFX-6516_Add-test-for-SDP_ASM branch from 42b8feb to 103f5d1 Compare January 13, 2025 09:34

nordic-segl commented Jan 14, 2025

View reviewed changes

nordic-bami approved these changes Jan 16, 2025

View reviewed changes

nordic-pikr approved these changes Jan 16, 2025

View reviewed changes

nordicjm approved these changes Jan 17, 2025

View reviewed changes

masz-nordic approved these changes Jan 17, 2025

View reviewed changes

masz-nordic merged commit 49dbb06 into nrfconnect:main Jan 17, 2025
12 checks passed

nordic-segl deleted the NRFX-6516_Add-test-for-SDP_ASM branch January 17, 2025 11:56

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

tests: drivers: Add test for SDP ASM #19857

tests: drivers: Add test for SDP ASM #19857

nordic-segl commented Jan 13, 2025

NordicBuilder commented Jan 13, 2025 •

edited

Loading

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025 •

edited

Loading

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025 •

edited

Loading

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl Jan 14, 2025

nordic-segl commented Jan 15, 2025

tests: drivers: Add test for SDP ASM #19857

tests: drivers: Add test for SDP ASM #19857

Conversation

nordic-segl commented Jan 13, 2025

NordicBuilder commented Jan 13, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordic-segl Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordic-segl Jan 14, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

nordic-segl commented Jan 15, 2025

NordicBuilder commented Jan 13, 2025 •

edited

Loading

nordic-segl Jan 14, 2025 •

edited

Loading

nordic-segl Jan 14, 2025 •

edited

Loading