Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NCSDK-30809: Add flash ipuc driver #19915

Conversation

tomchy
Copy link
Contributor

@tomchy tomchy commented Jan 15, 2025

No description provided.

@tomchy tomchy requested review from a team as code owners January 15, 2025 09:15
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 15, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Jan 15, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: 63f766b53edb93a69c8777249a6a0d4b21645bb3

more details

sdk-nrf:

PR head: 63f766b53edb93a69c8777249a6a0d4b21645bb3
merge base: 66ab9ae656990edaf8191f0f5e80e3ed9c742e5a
target head (main): 66ab9ae656990edaf8191f0f5e80e3ed9c742e5a
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (14)
.github
│  │ test-spec.yml
CODEOWNERS
drivers
│  ├── flash
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── flash_ipuc
│  │  │  ├── CMakeLists.txt
│  │  │  │ flash_ipuc.c
include
│  ├── drivers
│  │  ├── flash
│  │  │  │ flash_ipuc.h
tests
│  ├── drivers
│  │  ├── flash
│  │  │  ├── flash_ipuc
│  │  │  │  ├── CMakeLists.txt
│  │  │  │  ├── boards
│  │  │  │  │  ├── native_sim.conf
│  │  │  │  │  │ native_sim_64.conf
│  │  │  │  ├── mocks
│  │  │  │  │  │ mock_suit_ipuc.h
│  │  │  │  ├── prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: 342151af73
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:342151af73_912848a074

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 39
  • ✅ Integration tests
    • ⚠️ test-fw-nrfconnect-fw-update
    • ⚠️ test-fw-nrfconnect-nrf-iot_cloud
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@tomchy tomchy force-pushed the feature/suit/NCSDK-30809_Add_flash_ipuc_driver_part1 branch from a25555f to 3e8768e Compare January 15, 2025 12:29
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Jan 15, 2025
@tomchy tomchy force-pushed the feature/suit/NCSDK-30809_Add_flash_ipuc_driver_part1 branch from 3e8768e to 0a7ac5f Compare January 15, 2025 12:37
@tomchy tomchy requested a review from a team as a code owner January 15, 2025 12:37
Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build system changes approved.

@tomchy tomchy force-pushed the feature/suit/NCSDK-30809_Add_flash_ipuc_driver_part1 branch 2 times, most recently from 4ccb94f to ca552a3 Compare January 16, 2025 15:43
@tomchy tomchy requested a review from ahasztag January 20, 2025 09:52
Add pseudo-driver to access NVM memory through flash API using IPUC SSF
services.

Ref: NCSDK-30809

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
Add tests for the pseudo-flash driver that writes data through SUIT
IPUC.

Ref: NCSDK-30809

Signed-off-by: Tomasz Chyrowicz <tomasz.chyrowicz@nordicsemi.no>
@tomchy tomchy force-pushed the feature/suit/NCSDK-30809_Add_flash_ipuc_driver_part1 branch from ca552a3 to 63f766b Compare January 20, 2025 14:28
Copy link
Contributor

@bjarki-andreasen bjarki-andreasen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not gonna pretend I know what IPUC is, but the code looks fine and well tested :)

@tomchy tomchy merged commit 085e5a6 into nrfconnect:main Jan 24, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants