Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

applications: sdp: mspi: add calculating counter value #20209

Merged
merged 3 commits into from
Mar 6, 2025
Merged

applications: sdp: mspi: add calculating counter value #20209

merged 3 commits into from
Mar 6, 2025

Conversation

magp-nordic
Copy link
Contributor

@magp-nordic magp-nordic commented Feb 5, 2025 •
edited
Loading

Add calculating VTIM CNT0 top value based on desired frequency.
Needs #20320 to make CI green.

@magp-nordic magp-nordic requested review from a team as code owners February 5, 2025 13:57
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 5, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 5, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 18

Inputs:

Sources:

sdk-nrf: PR head: 9160e52ae72ffb3dd0fac8bb63880ff811c5084b

more details

sdk-nrf:

PR head: 9160e52ae72ffb3dd0fac8bb63880ff811c5084b
merge base: ae6959de89fc693fd962ec8a69bf0fac3af47736
target head (main): 26bafa336d6b016b4d7f9005fadacfc70a73f4c1
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5) 
applications
│  ├── sdp
│  │  ├── mspi
│  │  │  ├── src
│  │  │  │  ├── hrt
│  │  │  │  │  ├── hrt-nrf54l15.s
│  │  │  │  │  │ hrt.c
│  │  │  │  │ main.c
drivers
│  ├── mspi
│  │  │ mspi_nrfe.c
include
│  ├── drivers
│  │  ├── mspi
│  │  │  │ nrfe_mspi.h

Outputs:

Toolchain

Version: acee3b0b2b
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:acee3b0b2b_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 39
  • ✅ Integration tests
    • ✅ test-low-level
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from 0e04fa4 to eb0a5a8 Compare February 5, 2025 14:36
@masz-nordic masz-nordic added this to the 3.0.0 milestone Feb 7, 2025
@masz-nordic
Copy link
Contributor

@magp-nordic CI is red

@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from eb0a5a8 to 8cb8290 Compare February 10, 2025 11:38
@magp-nordic magp-nordic mentioned this pull request Feb 19, 2025
Merged
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from 8cb8290 to c095118 Compare February 25, 2025 14:11
@github-actions GitHub Actions
Copy link

After documentation is built, you will find the preview for this PR here.

@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch 2 times, most recently from 714e36a to 7d22dfc Compare February 25, 2025 17:10
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch 2 times, most recently from 429d26d to f7d8724 Compare February 26, 2025 13:55
@github-actions GitHub Actions
Copy link

You can find the documentation preview for this PR here.

@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from f7d8724 to c8bf6c9 Compare March 4, 2025 08:35
@magp-nordic magp-nordic requested a review from masz-nordic March 5, 2025 10:30
@mif1-nordic mif1-nordic mentioned this pull request Mar 5, 2025
Merged
mif1-nordic
mif1-nordic reviewed Mar 5, 2025
View reviewed changes
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch 2 times, most recently from feb27a3 to b3643cf Compare March 6, 2025 10:52
@magp-nordic
applications: sdp: mspi: add fix for max frequency
51571a6 
Add temporary fix for not starting VTIM when max frequency
is set (counter value 0).

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from b3643cf to dd735cc Compare March 6, 2025 11:03
@magp-nordic magp-nordic requested a review from mif1-nordic March 6, 2025 11:04
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from dd735cc to 3495a22 Compare March 6, 2025 11:06
@magp-nordic
drivers: mspi: add calculating CNT0 value
3b6d1aa 
Add calculating VTIM CNT0 value base don required frequency.
Also, add checking if required frequency is not too small.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic
applications: sdp: mspi: add setting CNT0 value
9160e52 
Add setting CNT0 value to the one received from APP.

Signed-off-by: Magdalena Pastula <magdalena.pastula@nordicsemi.no>
@magp-nordic magp-nordic force-pushed the NRFX-6703-tx-timing-alignment-for-l15 branch from 3495a22 to 9160e52 Compare March 6, 2025 11:08
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@masz-nordic masz-nordic merged commit f4ce409 into nrfconnect:main Mar 6, 2025
14 checks passed
@magp-nordic magp-nordic deleted the NRFX-6703-tx-timing-alignment-for-l15 branch March 6, 2025 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@masz-nordic masz-nordic masz-nordic approved these changes

@mif1-nordic mif1-nordic mif1-nordic approved these changes

Assignees
No one assigned
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
4 participants
@magp-nordic @NordicBuilder @masz-nordic @mif1-nordic