Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

suit: Remove ECDSA support #20247

Closed
wants to merge 1 commit into from

Conversation

ahasztag
Copy link
Contributor

@ahasztag ahasztag commented Feb 7, 2025

The algorithm is not supported by SUIT due to key storage limitations.

@ahasztag ahasztag requested review from a team as code owners February 7, 2025 12:13
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 7, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 7, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 947f7b0076da4285d79a41176d3dea1a36683aa9
suit-generator: PR head: 0a8712aa142490deb02ca39c4bb150c70c66f835

more details

sdk-nrf:

PR head: 947f7b0076da4285d79a41176d3dea1a36683aa9
merge base: f195846dd804cd7ee3f4881ddcb3d0de99e7de74
target head (main): fbeab7583ecb2bc6bf611a6f497ccc92076d1f03
Diff

suit-generator:

PR head: 0a8712aa142490deb02ca39c4bb150c70c66f835
merge base: 2e22c176ba50930604519c3f70ee8ae5ba2a09ac
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (16)
modules
│  ├── lib
│  │  ├── suit-generator
│  │  │  ├── ncs
│  │  │  │  ├── Kconfig
│  │  │  │  ├── build.py
│  │  │  │  ├── encrypt_script.py
│  │  │  │  │ sign_script.py
│  │  │  ├── suit_generator
│  │  │  │  ├── cmd_encrypt.py
│  │  │  │  ├── cmd_sign.py
│  │  │  │  │ suit_sign_script_base.py
│  │  │  ├── tests
│  │  │  │  ├── encrypt_script_mock.py
│  │  │  │  ├── kms_script_mock.py
│  │  │  │  ├── sign_script_mock.py
│  │  │  │  ├── test_cmd_encrypt.py
│  │  │  │  ├── test_cmd_sign.py
│  │  │  │  ├── test_ncs_encrypt_script.py
│  │  │  │  │ test_ncs_sign_script.py
sysbuild
│  │ Kconfig.suit
west.yml

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister - Skipped: Skipping Build & Test as it succeeded in a previous run: 3
  • ✅ Integration tests
    • ✅ test-sdk-audio - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ desktop52_verification - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-boot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-apps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test_ble_nrf_config - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_mesh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ble_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-chip - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nfc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ doc-internal - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91 - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf_crypto - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-proprietary_esb - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rpc - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-rs - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-fem - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-tfm - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-thread - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-zigbee - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-find-my - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_mosh - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-nrf-iot_positioning - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-sidewalk - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-wifi - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-low-level - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-pmic-samples - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-mcuboot - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-sdk-dfu - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-fw-nrfconnect-ps - Skipped: Job was skipped as it succeeded in a previous run
    • ✅ test-secdom-samples-public - Skipped: Job was skipped as it succeeded in a previous run

Note: This message is automatically posted and updated by the CI

@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 7, 2025

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff
suit-generator nrfconnect/suit-generator@2e22c17 nrfconnect/suit-generator@0a8712a (main) nrfconnect/suit-generator@2e22c176..0a8712aa

All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@ahasztag ahasztag force-pushed the remove_ecdsa_support branch from 22f0986 to 99b02a7 Compare February 18, 2025 13:49
@NordicBuilder NordicBuilder removed the DNM label Feb 18, 2025
The algorithm is not supported by SUIT due to key storage
limitations.

Signed-off-by: Artur Hadasz <artur.hadasz@nordicsemi.no>
@ahasztag ahasztag force-pushed the remove_ecdsa_support branch from 99b02a7 to 947f7b0 Compare February 19, 2025 07:09
@ahasztag ahasztag closed this Feb 21, 2025
@ahasztag ahasztag deleted the remove_ecdsa_support branch February 21, 2025 10:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. manifest manifest-suit-generator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants