Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nrf_modem_lib: don't require POSIX sockets names #20302

Closed
wants to merge 1 commit into from

Conversation

bandogora
Copy link

  • Replace POSIX API macros with Zephyr socket API (ZSOCK) macros in sanity.c
  • Don't imply NET_SOCKETS_POSIX_NAMES if !POSIX_API

CONFIG_POSIX_API enables experimental symbols and the NET_SOCKETS_POSIX_NAMES symbol is deprecated. POSIX names don't seems to be required for the library with the exception of 8 BUILD_ASSERTs. All of those BUILD_ASSERTs use POSIX macros that are aliases for ZSOCK macros.

@bandogora bandogora requested review from a team as code owners February 11, 2025 21:57
@CLAassistant
Copy link

CLAassistant commented Feb 11, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 11, 2025
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Feb 11, 2025
- Replace POSIX API macros with Zephyr socket API (ZSOCK) macros in sanity.c
- Don't imply NET_SOCKETS_POSIX_NAMES if !POSIX_API

CONFIG_POSIX_API enables experimental symbols and the
NET_SOCKETS_POSIX_NAMES symbol is deprecated. POSIX names don't seems to
be required for the library with the exception of 8 BUILD_ASSERTs. All of
those BUILD_ASSERTs use POSIX macros that are aliases for ZSOCK macros.

Signed-off-by: Justin Forgue <code@jes.contact>
@rlubos
Copy link
Contributor

rlubos commented Feb 12, 2025

@bandogora There are more changes needed in libraries/samples related to removing NET_SOCKETS_POSIX_NAMES , however good news is all this is already being addressed in the upmerge PR: #19720

@bandogora
Copy link
Author

is all this is already being addressed in the upmerge PR: #19720

Sounds good!

@bandogora bandogora closed this Feb 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants