-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework of nrf54l/soc.c to get rid of noup commits #20478
Conversation
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 7976e640417190636b66d94f901461755d43911c more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR at this link. Note: This comment is automatically posted by the Documentation Publish GitHub Action. |
61683ff
to
7bd5eac
Compare
7bd5eac
to
6f9afea
Compare
Since you changed how the frequency is set for 54l15 do you mind to update this: sdk-nrf/modules/trusted-firmware-m/Kconfig Line 329 in 1883f06
to get the current values in this PR as well? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/TFM/TF-M/
6f9afea
to
c165c20
Compare
After documentation is built, you will find the preview for this PR here. |
@Vge0rge done. Can you take a look? @tomi-font commit message updated. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Message of commit manifest: Update zephyr with changes in nrf54l soc.c
still has one TFM
. (I'll let Georgios ack on behalf of Aegir anyway.)
c165c20
to
4c4e08b
Compare
ah, the manifest commit. Forgot about that one. Fixed. |
4c4e08b
to
7c96fca
Compare
CPU in nRF54L Series does not specifiy clock-frequency in the cpu node. Cpu node indicated which clock source is used and frequency of that clock determines CPU frequency. Use hfpll frequency to get CPU frequency for nRF54L Series. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
Add errno.h to the kernel.h used for TF-M builds. Signed-off-by: Krzysztof Chruściński <krzysztof.chruscinski@nordicsemi.no>
7c96fca
to
7976e64
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Rework of zephyr nrf54l/soc.c file to get rid of TFM specific changes. Extended
kernel.h
used for TFM build to get rid of compilation errors.