Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate at_params, deprecate modem_info_type_get, add enum modem_info_data_type and modem_info_data_type_get #20497

Merged
merged 3 commits into from
Feb 24, 2025
Merged

Deprecate at_params, deprecate modem_info_type_get, add enum modem_info_data_type and modem_info_data_type_get #20497

merged 3 commits into from
Feb 24, 2025

Conversation

MirkoCovizzi
Copy link
Contributor

@MirkoCovizzi MirkoCovizzi commented Feb 19, 2025 •
edited
Loading

  • Deprecates the at_params module.
    It will be removed in a future release.

  • Adds the enum modem_info_data_type type
    for representing the LTE link information data
    types.

  • Adds the modem_info_data_type_get function
    for requesting the data type of the current
    modem information type.

  • Deprecates the modem_info_type_get function
    in favor of the modem_info_data_type_get function.

@MirkoCovizzi MirkoCovizzi self-assigned this Feb 19, 2025
@MirkoCovizzi MirkoCovizzi requested review from a team as code owners February 19, 2025 14:36
@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 19, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 19, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 22

Inputs:

Sources:

sdk-nrf: PR head: c16ca8022c8597e86aa150825eb371d327a2b7d9

more details

sdk-nrf:

PR head: c16ca8022c8597e86aa150825eb371d327a2b7d9
merge base: 254ece2b6dfb679e849cf44ae29aa1aa0640fa0c
target head (main): 755206cd93881593d38b292411b728192920ed12
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (8) 
doc
│  ├── nrf
│  │  ├── libraries
│  │  │  ├── modem
│  │  │  │  │ at_params.rst
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
include
│  ├── modem
│  │  ├── at_params.h
│  │  │ modem_info.h
lib
│  ├── modem_info
│  │  ├── modem_info.c
│  │  │ modem_info_params.c
subsys
│  ├── net
│  │  ├── lib
│  │  │  ├── nrf_cloud
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_cloud_codec_internal.c
tests
│  ├── subsys
│  │  ├── net
│  │  │  ├── lib
│  │  │  │  ├── nrf_provisioning
│  │  │  │  │  │ CMakeLists.txt

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 362
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_cloud
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • ✅ test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_lwm2m
    • ✅ test-fw-nrfconnect-nrf-iot_thingy91
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
    • ✅ test-fw-nrfconnect-nrf-iot_positioning
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@MirkoCovizzi MirkoCovizzi force-pushed the deprecate-at-params branch 4 times, most recently from 669701a to 9345ed7 Compare February 19, 2025 14:48
@MirkoCovizzi MirkoCovizzi changed the title Deprecate AT params Deprecate at_params, deprecate modem_info_type_get, add enum modem_info_data_type and modem_info_data_type_get Feb 19, 2025
@MirkoCovizzi MirkoCovizzi force-pushed the deprecate-at-params branch 3 times, most recently from 3cb1c92 to 716a4fc Compare February 19, 2025 15:14
@NordicBuilder
Copy link
Contributor

You can find the documentation preview for this PR at this link.

Note: This comment is automatically posted by the Documentation Publish GitHub Action.

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 20, 2025 •
edited
Loading

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/libraries/modem/at_params.html
https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/releases_and_maturity/releases/release-notes-changelog.html

eivindj-nordic
eivindj-nordic approved these changes Feb 20, 2025
View reviewed changes
@github-actions GitHub Actions
Copy link

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/libraries/modem/at_params.html
https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/releases_and_maturity/releases/release-notes-changelog.html

@github-actions GitHub Actions
Copy link

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/libraries/modem/at_params.html
https://ncsdoc.z6.web.core.windows.net/PR-20497/nrf/releases_and_maturity/releases/release-notes-changelog.html

@MirkoCovizzi MirkoCovizzi force-pushed the deprecate-at-params branch 2 times, most recently from cfd828f to 3223841 Compare February 21, 2025 08:56
@MirkoCovizzi MirkoCovizzi removed the DNM label Feb 21, 2025
@MirkoCovizzi
lib: at_cmd_parser: at_params: deprecate module
3ba062f 
Deprecates the `at_params` module.
It will be removed in a future release.

Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
@MirkoCovizzi
lib: modem_info: add data types
61e3ee2 
* Adds the `enum modem_info_data_type` type
  for representing the LTE link information data
  types.

* Adds the `modem_info_data_type_get` function
  for requesting the data type of the current
  modem information type.

Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
@MirkoCovizzi MirkoCovizzi force-pushed the deprecate-at-params branch 2 times, most recently from 4e1f92d to ae5378f Compare February 24, 2025 09:26
@MirkoCovizzi
lib: modem_info: deprecate modem_info_type_get
c16ca80 
Deprecates the `modem_info_type_get` function
in favor of the `modem_info_data_type_get` function.

Signed-off-by: Mirko Covizzi <mirko.covizzi@nordicsemi.no>
@MirkoCovizzi MirkoCovizzi requested a review from a team as a code owner February 24, 2025 10:49
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@nordicjm nordicjm merged commit 4c5b0f4 into nrfconnect:main Feb 24, 2025
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plskeggs plskeggs plskeggs approved these changes

@rlubos rlubos rlubos approved these changes

@nordicjm nordicjm nordicjm approved these changes

@peknis peknis peknis approved these changes

@eivindj-nordic eivindj-nordic eivindj-nordic approved these changes

@divipillai divipillai divipillai approved these changes

@pascal-nordic pascal-nordic pascal-nordic approved these changes

@anhmolt anhmolt Awaiting requested review from anhmolt

@lemrey lemrey Awaiting requested review from lemrey

Assignees

@MirkoCovizzi MirkoCovizzi

Labels
doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@MirkoCovizzi @NordicBuilder @plskeggs @rlubos @nordicjm @peknis @eivindj-nordic @divipillai @pascal-nordic