Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: cellular: modem_shell: Fix LTE cell printing during search #20506

Merged

Conversation

tokangas
Copy link
Contributor

Commit 8caef9d caused regression when printing LTE cell information during network search. This PR reverts the original functionality in link_api_xmonitor_read() and instead removes an error log which was printed when link_api_xmonitor_read() returned an error. It's simpler to let link_api_xmonitor_read() fail if cell ID and TAC can not be parsed.

Commit 8caef9d caused regression when printing LTE cell information
during network search. This PR reverts the original functionality in
link_api_xmonitor_read() and instead removes an error log which
was printed when link_api_xmonitor_read() returned an error. It's
simpler to let link_api_xmonitor_read() fail if cell ID and TAC
can not be parsed.

Signed-off-by: Tommi Kangas <tommi.kangas@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: cad600a861cad80a29d1549e6ed7b1e61a81d366

more details

sdk-nrf:

PR head: cad600a861cad80a29d1549e6ed7b1e61a81d366
merge base: 91ce90f992570664ed50ebbcfd23d3cf496a6d3a
target head (main): 3e3b689a6dffdf867f61f9d2bc438bf7e5eb7de7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (1)
samples
│  ├── cellular
│  │  ├── modem_shell
│  │  │  ├── src
│  │  │  │  ├── link
│  │  │  │  │  │ link_api.c

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 222
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_samples
    • ✅ test-fw-nrfconnect-nrf-iot_mosh
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@tokangas tokangas removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 20, 2025
@rlubos rlubos merged commit 11f3037 into nrfconnect:main Feb 20, 2025
14 checks passed
@tokangas tokangas deleted the mosh_fix_link_status_printing_once_more branch February 20, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants