bluetooth: fast_pair: fmdn: add restriction for fmdn tx power #20519
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
doc-required
|
After documentation is built, you will find the preview for this PR here. Preview links for modified nRF Connect SDK documents: https://ncsdoc.z6.web.core.windows.net/PR-20519/nrf/external_comp/bt_fast_pair.html |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 34565293d6fa36d8139399df3dc9a6c5a56c48f9 more detailssdk-nrf:
Github labels
List of changed files detected by CI (3)Outputs:ToolchainVersion: aedb4c0245 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
peknis
approved these changes
Feb 20, 2025
mkapala-nordic
approved these changes
Feb 20, 2025
MarekPieta
reviewed
Feb 20, 2025
MarekPieta
approved these changes
Feb 21, 2025
| @@ -580,6 +580,7 @@ For example, the "It's here" status message is displayed in the "Hot & Cold" exp | |||
|
|
|||
| You can set the TX power for the FMDN advertising and connections using the :kconfig:option:`CONFIG_BT_FAST_PAIR_FMDN_TX_POWER` Kconfig option. | |||
| The configured value is directly used to set the TX power in the Bluetooth LE controller using an HCI command. | |||
| This Kconfig option should be set to 0 at minimum as the Fast Pair specification requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. | |||
There was a problem hiding this comment.
Suggested change
| This Kconfig option should be set to 0 at minimum as the Fast Pair specification requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. | |
| This Kconfig option must be set to 0 at minimum as the Fast Pair specification requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. |
| * :ref:`bt_fast_pair_readme` library: | ||
|
|
||
| * Added a restriction on the :kconfig:option:`CONFIG_BT_FAST_PAIR_FMDN_TX_POWER` Kconfig option in the Find My Device Network (FMDN) extension configuration. | ||
| This Kconfig option should now be set to 0 at minimum as the Fast Pair specification now requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. |
There was a problem hiding this comment.
Suggested change
| This Kconfig option should now be set to 0 at minimum as the Fast Pair specification now requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. | |
| This Kconfig option must now be set to 0 at minimum as the Fast Pair specification now requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. |
| @@ -26,6 +26,10 @@ config BT_FAST_PAIR_FMDN_TX_POWER | |||
| procedure of this library. The actual TX power value will be as close to | |||
| the desired configuration as possible. | |||
|
|
|||
| This Kconfig should be set to zero at minimum. The Fast Pair specification | |||
There was a problem hiding this comment.
Suggested change
| This Kconfig should be set to zero at minimum. The Fast Pair specification | |
| This Kconfig must be set to zero at minimum. The Fast Pair specification |
| @@ -26,6 +26,10 @@ config BT_FAST_PAIR_FMDN_TX_POWER | |||
| procedure of this library. The actual TX power value will be as close to | |||
| the desired configuration as possible. | |||
|
|
|||
| This Kconfig should be set to zero at minimum. The Fast Pair specification | |||
| requires that the conducted Bluetooth transmit power for FMDN advertisements | |||
| should be set to at least 0 dBm. | |||
There was a problem hiding this comment.
Suggested change
| should be set to at least 0 dBm. | |
| must be set to at least 0 dBm. |
kapi-no
force-pushed
the
fp_fmdn_min_tx_power
branch
from
aaa58fe to
96a3b4b
Compare
|
@MarekPieta , addressed your comments |
MarekPieta
approved these changes
Feb 21, 2025
kapi-no
force-pushed
the
fp_fmdn_min_tx_power
branch
from
96a3b4b to
f395682
Compare
|
Simple rebase to resolve the conflicts |
kapi-no
force-pushed
the
fp_fmdn_min_tx_power
branch
from
f395682 to
547fabd
Compare
nordicjm
reviewed
Feb 24, 2025
Added a restriction on the CONFIG_BT_FAST_PAIR_FMDN_TX_POWER Kconfig option in the Find My Device Network (FMDN) extension configuration. This Kconfig option should now be set to 0 at minimum as the Fast Pair specification now requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm. Ref: NCSDK-30857 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>
kapi-no
force-pushed
the
fp_fmdn_min_tx_power
branch
from
547fabd to
3456529
Compare
|
nordicjm
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a restriction on the CONFIG_BT_FAST_PAIR_FMDN_TX_POWER Kconfig option in the Find My Device Network (FMDN) extension configuration. This Kconfig option should now be set to 0 at minimum as the Fast Pair specification now requires that the conducted Bluetooth transmit power for FMDN advertisements must not be lower than 0 dBm.
Ref: NCSDK-30857