Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: partition manager: split single test to multiple tests #20541

Merged
merged 2 commits into from
Feb 21, 2025

Conversation

fundakol
Copy link
Contributor

Extracted tests from partition_manager.py to pytest test file and added to CI execution.
Refactored partition manager test to multiple tests to have better coverage for each functionality.

Signed-off-by: Lukasz Fundakowski lukasz.fundakowski@nordicsemi.no

Extracted tests from partition_manager.py
to pytest test file and added to CI execution.

Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
@fundakol fundakol requested review from a team as code owners February 20, 2025 15:43
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 20, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 20, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 07d4a7611ce4e522c496b4d4920885b4d95a2537

more details

sdk-nrf:

PR head: 07d4a7611ce4e522c496b4d4920885b4d95a2537
merge base: 3e3b689a6dffdf867f61f9d2bc438bf7e5eb7de7
target head (main): 96683e2782923209e3f4bb9e6e0b48db770afee7
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (7)
.github
│  ├── workflows
│  │  │ scripts-test.yml
CODEOWNERS
scripts
│  ├── partition_manager.py
│  ├── requirements-test.txt
│  ├── tests
│  │  ├── __init__.py
│  │  ├── conftest.py
│  │  │ partition_manager_test.py

Outputs:

Toolchain

Version: 4cff34261a
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4cff34261a_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 28
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@fundakol fundakol force-pushed the partition-manager-script branch from 64a25ee to 2f5c91b Compare February 21, 2025 09:12
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 21, 2025
Refactored partition manager test to multiple
tests to have better coverage for each
functionality.

Signed-off-by: Lukasz Fundakowski <lukasz.fundakowski@nordicsemi.no>
@fundakol fundakol force-pushed the partition-manager-script branch from 2f5c91b to 07d4a76 Compare February 21, 2025 11:33
Copy link
Contributor

@gchwier gchwier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks and works great!
Consider updating nrf/.github/test-spec.yml, section "CI-boot-test", with line
- "scripts/partition_manager*"
it triggers our downstream jobs when partition_manager script will be udated.
Not necessary in that PR, but maybe when planning other changes to that script.

@rlubos rlubos merged commit 2ad79c6 into nrfconnect:main Feb 21, 2025
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants