Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: nrf: add nrf_security APIs to the Doxygen input #20612

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gmarull
Copy link
Member

@gmarull gmarull commented Feb 26, 2025

...so that they are processed and rendered by Doxygen. Note that grouping
is still needed so that headers appear nicely in the "Topics" page.
This is a task left to the maintainers of such code.

@gmarull gmarull requested a review from umapraseeda February 26, 2025 09:18
@gmarull gmarull requested review from a team as code owners February 26, 2025 09:18
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 26, 2025
Copy link

After documentation is built, you will find the preview for this PR here.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 26, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 2

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@gmarull gmarull added the CI-disable Disable CI for this PR label Feb 26, 2025
gmarull added 2 commits March 5, 2025 12:02
Headers had numerous Doxygen issues, this patch fixes all of them
so that Doxygen build is clean from warnings/errors.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
So that they are processed and rendered by Doxygen. Note that grouping
is still needed so that headers appear nicely in the "Topics" page.
This is a task left to the maintainers of such code.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
@gmarull gmarull force-pushed the nrf-security-doxygen branch from 040cdba to 4d94f99 Compare March 5, 2025 11:02
Copy link

sonarqubecloud bot commented Mar 5, 2025

Copy link

github-actions bot commented Mar 5, 2025

You can find the documentation preview for this PR here.

Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original task NCSDK-30040 is requesting the inclusion of files under ncs/modules/crypto/oberon-psa-crypto/include/psa/, while this PR is including subsys/nrf_security/include (as per a follow-up request in a comment to NCSDK-30040).

Is it possible to satisfy the original requirement of including files from ncs/modules/crypto/oberon-psa-crypto/include/psa/, which are above the sdk-nrf dir?

@gmarull
Copy link
Member Author

gmarull commented Mar 27, 2025

The original task NCSDK-30040 is requesting the inclusion of files under ncs/modules/crypto/oberon-psa-crypto/include/psa/, while this PR is including subsys/nrf_security/include (as per a follow-up request in a comment to NCSDK-30040).

Is it possible to satisfy the original requirement of including files from ncs/modules/crypto/oberon-psa-crypto/include/psa/, which are above the sdk-nrf dir?

If those headers contain valid Doxygen, maybe. You can easily try that based on this PR, I do not know which structure you need/want.

@greg-fer
Copy link
Contributor

The original task NCSDK-30040 is requesting the inclusion of files under ncs/modules/crypto/oberon-psa-crypto/include/psa/, while this PR is including subsys/nrf_security/include (as per a follow-up request in a comment to NCSDK-30040).
Is it possible to satisfy the original requirement of including files from ncs/modules/crypto/oberon-psa-crypto/include/psa/, which are above the sdk-nrf dir?

If those headers contain valid Doxygen, maybe. You can easily try that based on this PR, I do not know which structure you need/want.

Unfortunately, they have the same issues as you are fixing in this PR. Lots of /emptydescription or broken linkage.

I think the best would be to have this PR merged, and then I can continue to experiment separately with the structure.

Copy link
Contributor

@greg-fer greg-fer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Specific API structure will be part of a subsequent PR.

Comment on lines +96 to +99
* \retval #PSA_ERROR_COMMUNICATION_FAILURE
* \retval PSA_ERROR_CORRUPTION_DETECTED
* \retval #PSA_ERROR_STORAGE_FAILURE
* \retval PSA_ERROR_DATA_INVALID
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do certain defines now start with # and others not?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants