samples: benchmarks: coremark: add FLPR support for nRF54H20 DK #20614

kapi-no · 2025-02-26T09:45:07Z

Added the FLPR core support for the nRF54H20 DK board target in the CoreMark sample.

Ref: NCSDK-30327

github-actions · 2025-02-26T09:45:31Z

After documentation is built, you will find the preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20614/nrf/releases_and_maturity/releases/release-notes-changelog.html
https://ncsdoc.z6.web.core.windows.net/PR-20614/nrf/samples/benchmarks/coremark/README.html

NordicBuilder · 2025-02-26T09:49:10Z

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 4

Inputs:

Sources:

sdk-nrf: PR head: 690e47963885221804f46c864545a6abc876edce

more details

sdk-nrf:

PR head: 690e47963885221804f46c864545a6abc876edce
merge base: 81607ffdd26a1629f0ffc8a42bb46476f3010fbc
target head (main): 200fdcd9a9d7cd1c869e1fe2779a870b31f23a57
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (13)

doc
│  ├── nrf
│  │  ├── releases_and_maturity
│  │  │  ├── releases
│  │  │  │  │ release-notes-changelog.rst
samples
│  ├── benchmarks
│  │  ├── coremark
│  │  │  ├── Kconfig.sysbuild
│  │  │  ├── README.rst
│  │  │  ├── boards
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuapp.overlay
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuflpr.conf
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuflpr.overlay
│  │  │  │  ├── nrf54h20dk_nrf54h20_cpuppr.conf
│  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.conf
│  │  │  ├── prj.conf
│  │  │  ├── prj_flash_and_run.conf
│  │  │  ├── prj_heap_memory.conf
│  │  │  ├── prj_multiple_threads.conf
│  │  │  │ prj_static_memory.conf

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

◻️ Toolchain - Skipped: existing toolchain is used
✅ Build twister
- sdk-nrf test count: 42
✅ Integration tests

Disabled integration tests

- desktop52_verification
- doc-internal
- test-fw-nrfconnect-apps
- test-fw-nrfconnect-ble_mesh
- test-fw-nrfconnect-ble_samples
- test-fw-nrfconnect-boot
- test-fw-nrfconnect-chip
- test-fw-nrfconnect-fem
- test-fw-nrfconnect-nfc
- test-fw-nrfconnect-nrf-iot_libmodem-nrf
- test-fw-nrfconnect-nrf-iot_lwm2m
- test-fw-nrfconnect-nrf-iot_mosh
- test-fw-nrfconnect-nrf-iot_positioning
- test-fw-nrfconnect-nrf-iot_samples
- test-fw-nrfconnect-nrf-iot_serial_lte_modem
- test-fw-nrfconnect-nrf-iot_thingy91
- test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
- test-fw-nrfconnect-nrf_crypto
- test-fw-nrfconnect-proprietary_esb
- test-fw-nrfconnect-ps
- test-fw-nrfconnect-rpc
- test-fw-nrfconnect-rs
- test-fw-nrfconnect-tfm
- test-fw-nrfconnect-thread
- test-fw-nrfconnect-zigbee
- test-low-level
- test-sdk-audio
- test-sdk-dfu
- test-sdk-find-my
- test-sdk-mcuboot
- test-sdk-pmic-samples
- test-sdk-sidewalk
- test-sdk-wifi
- test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

annwoj · 2025-02-26T10:02:03Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

@@ -577,7 +577,7 @@ Other samples
  * Added:

    * Support for the nRF54L05 and nRF54L10 SoCs (emulated on nRF54L15 DK).
-    * FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` board target.
+    * FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` and the :ref:`zephyr:nrf54h20dk_nrf54h20` board target.


Suggested change

* FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` and the :ref:`zephyr:nrf54h20dk_nrf54h20` board target.

* FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` and :ref:`zephyr:nrf54h20dk_nrf54h20` board targets.

zycz

LGTM

samples/benchmarks/coremark/boards/nrf54h20dk_nrf54h20_cpuflpr.conf

MarekPieta · 2025-02-26T11:12:56Z

samples/benchmarks/coremark/boards/nrf54h20dk_nrf54h20_cpuflpr.conf

+
+# Reduce speed optimizations to fit the sample into the TCM of the FLPR core.
+# Removed the following options from the default configuration (prj.conf):
+# -funroll-loops


I wonder if we could add another optimizations to allow using -funroll-loops (we need to optimize RAM usage by ~10 kbytes). @zycz do you think we should open a follow-up ticket for it? Would it be worth to optimize it further?

kapi-no · 2025-02-26T12:52:23Z

Rebase on top of the main branch to include the fix for double logs from the nRF54H20 cpuapp target. No file diff has changed.

github-actions · 2025-02-26T13:13:01Z

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20614/nrf/releases_and_maturity/releases/release-notes-changelog.html
https://ncsdoc.z6.web.core.windows.net/PR-20614/nrf/samples/benchmarks/coremark/README.html

tejlmand

Looking fine, just an observation to be clarified.

tejlmand · 2025-03-03T10:36:46Z

samples/benchmarks/coremark/boards/nrf54h20dk_nrf54h20_cpuflpr.conf

+# Reduce speed optimizations to fit the sample into the TCM of the FLPR core.
+# Removed the following options from the default configuration (prj.conf):
+# -funroll-loops
+CONFIG_COMPILER_OPT="-O3 -fno-lto -fno-pie -fno-pic -ffunction-sections -fdata-sections"


-fno-pie -fno-pic are default in Zephyr, sop why are they added here ?
-ffunction-sections -fdata-sections" are default in Zephyr, sop why are they added here ?

This is a copy-paste of the original options from prj.conf (minus -funroll-loops). @zycz, why did you add them?

I got them from SAG experiments.

We also wanted to mention them explicitly to show them in output logs - we use this variable here:

#define COMPILER_FLAGS CONFIG_COMPILER_OPT " + see compiler flags added by Zephyr"

but I guess we don't have to add it as we already mention that we use default zephyr flags

okay, so I will clean up these flags

Corrected comments in the Radio, PPR and FLPR configurations regarding the consistency between the DTS and Kconfig configurations for the UART functionality. Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>

Removed compiler options in the CoreMark sample that are already included by default in Zephyr. Ref: NCSDK-30327 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>

Added the FLPR core support for the nRF54H20 DK board target in the CoreMark sample. Ref: NCSDK-30327 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>

sonarqubecloud · 2025-03-03T13:32:36Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

peknis

Approved with a nit.

peknis · 2025-03-04T07:12:24Z

doc/nrf/releases_and_maturity/releases/release-notes-changelog.rst

+    * ``-ffunction-sections``
+    * ``-fdata-sections``
+
+    These options are enabled by default in Zephyr and do not need to be set with the dedicated Kconfig option.


Suggested change

These options are enabled by default in Zephyr and do not need to be set with the dedicated Kconfig option.

These options are enabled by default in Zephyr.

You do not need to set them with a dedicated Kconfig option.

discussed in the other comm channel, decide to keep it as it is

kapi-no requested review from a team as code owners February 26, 2025 09:45

github-actions bot added the doc-required PR must not be merged without tech writer approval. label Feb 26, 2025

mkapala-nordic approved these changes Feb 26, 2025

View reviewed changes

annwoj reviewed Feb 26, 2025

View reviewed changes

peknis approved these changes Feb 26, 2025

View reviewed changes

zycz approved these changes Feb 26, 2025

View reviewed changes

MarekPieta approved these changes Feb 26, 2025

View reviewed changes

kapi-no force-pushed the coremark_flpr_support_nrf54h branch from c2bb431 to 5d61f36 Compare February 26, 2025 12:47

kapi-no requested a review from annwoj February 26, 2025 12:48

kapi-no force-pushed the coremark_flpr_support_nrf54h branch from 5d61f36 to a3b3a70 Compare February 26, 2025 12:51

annwoj approved these changes Feb 26, 2025

View reviewed changes

tejlmand reviewed Mar 3, 2025

View reviewed changes

kapi-no added 3 commits March 3, 2025 14:23

samples: benchmarks: coremark: remove redundant compiler options

3ea77af

Removed compiler options in the CoreMark sample that are already included by default in Zephyr. Ref: NCSDK-30327 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>

samples: benchmarks: coremark: add FLPR support for nRF54H20 DK

690e479

Added the FLPR core support for the nRF54H20 DK board target in the CoreMark sample. Ref: NCSDK-30327 Signed-off-by: Kamil Piszczek <Kamil.Piszczek@nordicsemi.no>

kapi-no force-pushed the coremark_flpr_support_nrf54h branch from a3b3a70 to 690e479 Compare March 3, 2025 13:27

kapi-no requested a review from tejlmand March 3, 2025 13:28

tejlmand approved these changes Mar 3, 2025

View reviewed changes

mkapala-nordic approved these changes Mar 3, 2025

View reviewed changes

zycz approved these changes Mar 3, 2025

View reviewed changes

peknis approved these changes Mar 4, 2025

View reviewed changes

kapi-no merged commit 94533b8 into nrfconnect:main Mar 4, 2025
14 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

samples: benchmarks: coremark: add FLPR support for nRF54H20 DK #20614

samples: benchmarks: coremark: add FLPR support for nRF54H20 DK #20614

kapi-no commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

NordicBuilder commented Feb 26, 2025 •

edited

Loading

annwoj Feb 26, 2025

kapi-no Feb 26, 2025

zycz left a comment

MarekPieta Feb 26, 2025

kapi-no commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

tejlmand left a comment

tejlmand Mar 3, 2025

kapi-no Mar 3, 2025 •

edited

Loading

zycz Mar 3, 2025

kapi-no Mar 3, 2025

kapi-no Mar 3, 2025

sonarqubecloud bot commented Mar 3, 2025

peknis left a comment

peknis Mar 4, 2025

kapi-no Mar 4, 2025

	* FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` and the :ref:`zephyr:nrf54h20dk_nrf54h20` board target.
	* FLPR core support for the :ref:`zephyr:nrf54l15dk_nrf54l15` and :ref:`zephyr:nrf54h20dk_nrf54h20` board targets.

	These options are enabled by default in Zephyr and do not need to be set with the dedicated Kconfig option.
	These options are enabled by default in Zephyr.
	You do not need to set them with a dedicated Kconfig option.

samples: benchmarks: coremark: add FLPR support for nRF54H20 DK #20614

samples: benchmarks: coremark: add FLPR support for nRF54H20 DK #20614

Conversation

kapi-no commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

NordicBuilder commented Feb 26, 2025 • edited Loading

CI Information

Inputs:

Sources:

Github labels

Outputs:

Toolchain

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

Choose a reason for hiding this comment

Choose a reason for hiding this comment

zycz left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kapi-no commented Feb 26, 2025

github-actions bot commented Feb 26, 2025

tejlmand left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kapi-no Mar 3, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

sonarqubecloud bot commented Mar 3, 2025

Quality Gate passed

peknis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

NordicBuilder commented Feb 26, 2025 •

edited

Loading

kapi-no Mar 3, 2025 •

edited

Loading