Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: benchmarks: multicore: Remote GDF switching #20625

Merged
merged 1 commit into from
Mar 3, 2025

Conversation

nordic-pikr
Copy link
Contributor

@nordic-pikr nordic-pikr commented Feb 26, 2025

Add test cases for fast counter, pwm, spim, uarte instances where global domain frequency is changed from remote application. Use solution for synchronization of host and remote core like in idle_pwm_loopback case.

test_low_level: PR-1912

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 26, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 26, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 11

Inputs:

Sources:

sdk-nrf: PR head: c769ef86f95c08596a4c5aaa52b3ace89286e36d

more details

sdk-nrf:

PR head: c769ef86f95c08596a4c5aaa52b3ace89286e36d
merge base: 4dfdc18cd66f89855dfa516a750a09cf219cfc97
target head (main): 4dfdc18cd66f89855dfa516a750a09cf219cfc97
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (20)
tests
│  ├── benchmarks
│  │  ├── multicore
│  │  │  ├── common
│  │  │  │  ├── remote_gdf_switching
│  │  │  │  │  ├── CMakeLists.txt
│  │  │  │  │  ├── boards
│  │  │  │  │  │  │ nrf54h20dk_nrf54h20_cpurad.overlay
│  │  │  │  │  ├── prj.conf
│  │  │  │  │  ├── src
│  │  │  │  │  │  │ main.c
│  │  │  ├── idle_counter
│  │  │  │  ├── Kconfig
│  │  │  │  ├── prj.conf
│  │  │  │  ├── remote
│  │  │  │  │  ├── Kconfig
│  │  │  │  │  │ prj.conf
│  │  │  │  ├── src
│  │  │  │  │  │ main.c
│  │  │  │  ├── sysbuild.cmake
│  │  │  │  │ testcase.yaml
│  │  │  ├── idle_pwm_loopback
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  ├── sysbuild.cmake
│  │  │  │  │ testcase.yaml
│  │  │  ├── idle_spim_loopback
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  ├── sysbuild.cmake
│  │  │  │  │ testcase.yaml
│  │  │  ├── idle_uarte
│  │  │  │  ├── Kconfig.sysbuild
│  │  │  │  ├── sysbuild.cmake
│  │  │  │  │ testcase.yaml

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 143
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@nordic-pikr nordic-pikr marked this pull request as ready for review February 26, 2025 12:35
@nordic-pikr nordic-pikr requested review from a team as code owners February 26, 2025 12:35
@@ -1,11 +1,10 @@
#
# Copyright (c) 2024 Nordic Semiconductor ASA
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe that copyright year is a year when a new file was added.
Thus, any change to the existing file shall not change the year.
Am I correct?

@nordic-pikr nordic-pikr force-pushed the remote_gdf branch 3 times, most recently from 6003a4f to cd6c2ba Compare February 26, 2025 15:13
@nordic-pikr nordic-pikr marked this pull request as draft February 27, 2025 08:55
@nordic-pikr nordic-pikr force-pushed the remote_gdf branch 3 times, most recently from 30e7669 to ea0c4c6 Compare February 27, 2025 12:02
Copy link

You can find the documentation preview for this PR here.

# Add remote project
ExternalZephyrProject_Add(
if(SB_CONFIG_SOC_NRF54H20)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

endif()
if(SB_CONFIG_SOC_NRF54H20)
if(SB_CONFIG_REMOTE_GLOBAL_DOMAIN_CLOCK_FREQUENCY_SWITCHING)
set(REMOTE_SOURCE_DIR ${ZEPHYR_NRF_MODULE_DIR}/tests/benchmarks/multicore/common/remote_gdf_switching)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 space cmake indent seems have gone to 4 here

fixture: gpio_loopback
pytest_root:
- "${CUSTOM_ROOT_TEST_DIR}/test_measure_power_consumption.py::test_measure_and_data_dump_power_consumption_gated_uarte"

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Add test cases for fast counter, pwm, spim, uarte
instances where global domain frequency is changed
from remote application. Use solution for
synchronization of host and remote core like in
idle_pwm_loopback case.

Signed-off-by: Piotr Krzyzanowski <piotr.krzyzanowski@nordicsemi.no>
@nordic-pikr nordic-pikr marked this pull request as ready for review February 28, 2025 14:50
@nordic-pikr nordic-pikr requested a review from nordicjm February 28, 2025 15:26
@nordic-piks nordic-piks merged commit 40b35ca into nrfconnect:main Mar 3, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants