samples: cellular: fixes and cleanup for new BT HCI driver

[mniestroj]

Update thingy91 to new HCI driver, so that Bluetooth driver is registered correctly during init.

Cleanup devicetree leftovers from old HCI driver, which are no longer used.

[NordicBuilder]

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[NordicBuilder]

CI Information

^{To view the history of this post, clich the 'edited' button above}
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 012392d4c5d9c0dd739d2f3471026f255c1bbfe8

more details

sdk-nrf:

PR head: 012392d4c5d9c0dd739d2f3471026f255c1bbfe8
merge base: bde6b19b00b74b47ce37a09f75e815064a0d4827
target head (main): db3aa5c59e10a3c14f3a6e66dfdffdae8ac7d658
Diff

Github labels

Enabled	Name	Description
	ci-disabled	Disable the ci execution
	ci-all-test	Run all of ci, no test spec filtering will be done
	ci-force-downstream	Force execution of downstream even if twister fails
	ci-run-twister	Force run twister
	ci-run-zephyr-twister	Force run zephyr twister

List of changed files detected by CI (5)

samples
│  ├── cellular
│  │  ├── lte_ble_gateway
│  │  │  ├── boards
│  │  │  │  ├── nrf9160dk_nrf9160_ns.overlay
│  │  │  │  │ thingy91_nrf9160_ns.overlay
│  │  │  │ prj.conf
│  │  ├── modem_shell
│  │  │  ├── bt.overlay
│  │  │  │ overlay-bt.conf

Outputs:

Toolchain

Version: aedb4c0245
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:aedb4c0245_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

• ◻️ Toolchain - Skipped: existing toolchain is used
• ✅ Build twister
  • sdk-nrf test count: 223
• ✅ Integration tests
  • ✅ test-fw-nrfconnect-nrf-iot_samples
  • ✅ test-fw-nrfconnect-nrf-iot_mosh

Disabled integration tests

• • desktop52_verification
  • doc-internal
  • test_ble_nrf_config
  • test-fw-nrfconnect-apps
  • test-fw-nrfconnect-ble_mesh
  • test-fw-nrfconnect-ble_samples
  • test-fw-nrfconnect-boot
  • test-fw-nrfconnect-chip
  • test-fw-nrfconnect-fem
  • test-fw-nrfconnect-nfc
  • test-fw-nrfconnect-nrf-iot_libmodem-nrf
  • test-fw-nrfconnect-nrf-iot_lwm2m
  • test-fw-nrfconnect-nrf-iot_positioning
  • test-fw-nrfconnect-nrf-iot_serial_lte_modem
  • test-fw-nrfconnect-nrf-iot_thingy91
  • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
  • test-fw-nrfconnect-nrf_crypto
  • test-fw-nrfconnect-proprietary_esb
  • test-fw-nrfconnect-ps
  • test-fw-nrfconnect-rpc
  • test-fw-nrfconnect-rs
  • test-fw-nrfconnect-tfm
  • test-fw-nrfconnect-thread
  • test-fw-nrfconnect-zigbee
  • test-low-level
  • test-sdk-audio
  • test-sdk-dfu
  • test-sdk-find-my
  • test-sdk-mcuboot
  • test-sdk-pmic-samples
  • test-sdk-sidewalk
  • test-sdk-wifi
  • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

[rlubos]

@jhirsi @tokangas @trantanen Ping, please review

[tokangas]

I'm not familiar with this modem_shell feature, but I followed the instructions and tried it. It does not seem to work. The bt init command causes a timeout after 10 seconds and asserts.

mosh:~$ bt init
mosh:~$ ASSERTION FAIL [success] @ WEST_TOPDIR/zephyr/subsys/bluetooth/host/hci_core.c:429
        command opcode 0x0c03 timeout

I also tried the lte_ble_gateway sample and looks like it works, so there might be something wrong with the modem_shell configuration. I did not reflash nRF52 between lte_ble_gateway and modem_shell trials, so it should be ok.

@mniestroj Did you try modem_shell? It is quite possible that this has been broken in modem_shell already earlier.

[tokangas]

Ok, I also needed to include the change in #20651. Now it works also with modem_shell. Thanks, @mniestroj!

[trantanen]

Thanks for the updates!
I'd probably combine the changes into two commits (one for each sample) but not a big deal unless @rlubos has an opinion on that.