Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: improved note in nRF Cloud multi-service sample #20657

Merged
merged 1 commit into from
Mar 6, 2025

Conversation

peknis
Copy link
Contributor

@peknis peknis commented Feb 27, 2025

Removed the note as it does not add any value.

@peknis peknis requested a review from a team as a code owner February 27, 2025 13:12
@github-actions github-actions bot added doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 27, 2025
@peknis peknis added CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval. and removed doc-required PR must not be merged without tech writer approval. changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Feb 27, 2025
@peknis peknis requested a review from coderbyheart February 27, 2025 13:13
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Feb 27, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

more details

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (0)

Outputs:

Toolchain

Version:
Build docker image:

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain
  • ◻️ Build twister
  • ◻️ Integration tests

Note: This message is automatically posted and updated by the CI

@peknis peknis force-pushed the multi-service-note branch from dd3a7ec to 32b206f Compare February 27, 2025 13:19
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Feb 27, 2025
@peknis peknis requested review from a team and jhn-nordic February 27, 2025 13:28
Copy link

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20657/nrf/samples/cellular/nrf_cloud_multi_service/README.html

Copy link
Contributor

@plskeggs plskeggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is fine with this change, though deceiving -- this particular sample does not support REST, only MQTT or CoAP. So it would be better to remove REST. Not sure why it mentioned that before.

@peknis
Copy link
Contributor Author

peknis commented Feb 28, 2025

It is fine with this change, though deceiving -- this particular sample does not support REST, only MQTT or CoAP. So it would be better to remove REST. Not sure why it mentioned that before.

Seems that the note is totally useless.

Clarified the protocol options in the note.

Signed-off-by: Pekka Niskanen <pekka.niskanen@nordicsemi.no>
@peknis peknis force-pushed the multi-service-note branch from 32b206f to 9076e11 Compare February 28, 2025 07:23
@peknis
Copy link
Contributor Author

peknis commented Feb 28, 2025

After discussing with Markku Lehto, decided to remove the note as it does not add any value in this context.

@peknis peknis requested a review from plskeggs February 28, 2025 07:24
@peknis peknis requested review from plskeggs and removed request for plskeggs March 6, 2025 09:05
@jhn-nordic jhn-nordic requested a review from pascal-nordic March 6, 2025 09:10
@rlubos rlubos merged commit ce10bed into nrfconnect:main Mar 6, 2025
14 checks passed
@peknis peknis deleted the multi-service-note branch March 6, 2025 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. CI-disable Disable CI for this PR doc-required PR must not be merged without tech writer approval.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants