Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

modules: add OpenThread platform implementation #20757

Merged

Conversation

maciejbaczmanski
Copy link
Member

@maciejbaczmanski maciejbaczmanski commented Mar 5, 2025

Copy OpenThread platform implementation from upstream Zephyr, based on commit 10eb60b48111d529ab30bae2a344226accb3ded6 to enable development of Nordic-specific platform implementation.

  • Start using NCS implementation of OT platform
  • align license allowlist
  • remove sourcing files that have not been copied from upstream
  • update CODEOWNERS
  • clean compliance issues
  • update test spec

Copy OpenThread platform implementation from upstream Zephyr,
based on commit 10eb60b48111d529ab30bae2a344226accb3ded6
to enable development of Nordic-specific platform implementation.

Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
@maciejbaczmanski maciejbaczmanski requested review from carlescufi, rlubos and a team March 5, 2025 15:05
@maciejbaczmanski maciejbaczmanski requested review from a team as code owners March 5, 2025 15:05
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 5, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 6

Inputs:

Sources:

sdk-nrf: PR head: b4fd08670e97444caf35f68e4ff19c395eab6cc3

more details

sdk-nrf:

PR head: b4fd08670e97444caf35f68e4ff19c395eab6cc3
merge base: cf8ba9d14e5986c242752465f7e7aeaf769ffdd8
target head (main): ae6959de89fc693fd962ec8a69bf0fac3af47736
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (27)
.github
│  │ test-spec.yml
CODEOWNERS
modules
│  ├── modules.cmake
│  ├── openthread
│  │  ├── CMakeLists.txt
│  │  ├── Kconfig
│  │  ├── Kconfig.features
│  │  ├── Kconfig.thread
│  │  ├── platform
│  │  │  ├── CMakeLists.txt
│  │  │  ├── alarm.c
│  │  │  ├── ble.c
│  │  │  ├── crypto_psa.c
│  │  │  ├── diag.c
│  │  │  ├── entropy.c
│  │  │  ├── logging.c
│  │  │  ├── memory.c
│  │  │  ├── messagepool.c
│  │  │  ├── misc.c
│  │  │  ├── openthread-core-zephyr-config.h
│  │  │  ├── platform-zephyr.h
│  │  │  ├── platform.c
│  │  │  ├── radio.c
│  │  │  ├── settings.c
│  │  │  ├── shell.c
│  │  │  ├── spi.c
│  │  │  │ uart.c
scripts
│  ├── ci
│  │  ├── license_allow_list.yaml
│  │  │ tags.yaml

Outputs:

Toolchain

Version: acee3b0b2b
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:acee3b0b2b_bece0367df

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 104
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-thread
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Mar 5, 2025

You can find the documentation preview for this PR here.

Copy link
Contributor

@rlubos rlubos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please take care of compliance.

Copy link
Contributor

@ArekBalysNordic ArekBalysNordic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejbaczmanski
Copy link
Member Author

@nrfconnect/ncs-co-build-system please review

@maciejbaczmanski
Copy link
Member Author

Quality Gate Failed Quality Gate failed

Failed conditions 1 Security Hotspot

See analysis details on SonarQube Cloud

Commands are parsed by OpenThread CLI. There is always a null terminator added https://github.com/openthread/openthread/blob/main/src/core/utils/parse_cmdline.cpp#L66

This fail is a false positive

@maciejbaczmanski maciejbaczmanski requested a review from a team as a code owner March 6, 2025 08:30
- Start using NCS implementation of OT platform
- align license allowlist
- remove sourcing files that have not been copied from upstream
- update CODEOWNERS
- clean compliance issues
- update test spec

Signed-off-by: Maciej Baczmanski <maciej.baczmanski@nordicsemi.no>
Copy link

sonarqubecloud bot commented Mar 6, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot

See analysis details on SonarQube Cloud

Copy link
Contributor

@katgiadla katgiadla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maciejbaczmanski
Copy link
Member Author

@nrfconnect/ncs-co-build-system PR is ready for merge. please review.

@maciejbaczmanski maciejbaczmanski merged commit 395d52f into nrfconnect:main Mar 6, 2025
17 of 18 checks passed
@maciejbaczmanski maciejbaczmanski deleted the ot_modules_platform branch March 6, 2025 14:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

10 participants