Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

scripts: shell: Fix bluetooth shell #20805

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

bao-eng
Copy link

@bao-eng bao-eng commented Mar 7, 2025

Restored the working order of the Bluetooth LE Console application.

@bao-eng bao-eng requested a review from a team as a code owner March 7, 2025 16:00
@CLAassistant
Copy link

CLAassistant commented Mar 7, 2025

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 7, 2025
@NordicBuilder
Copy link
Contributor

Thank you for your contribution!
It seems you are not a member of the nrfconnect GitHub organization. External contributions are handled as follows:
Large contributions, affecting multiple subsystems for example, may be rejected if they are complex, may introduce regressions due to lack of test coverage, or if they are not consistent with the architecture of nRF Connect SDK.
PRs will be run in our continuous integration (CI) test system.
If CI passes, PRs will be tagged for review and merged on successful completion of review. You may be asked to make some modifications to your contribution during review.
If CI fails, PRs may be rejected or may be tagged for review and rework.
PRs that become outdated due to other changes in the repository may be rejected or rework requested.
External contributions will be prioritized for review based on the relevance to current development efforts in nRF Connect SDK. Bug fix PRs will be prioritized.
You may raise issues or ask for help from our Technical Support team by visiting https://devzone.nordicsemi.com/.

Note: This comment is automatically posted and updated by the Contribs GitHub Action.

@NordicBuilder NordicBuilder added the external External contribution label Mar 7, 2025
@nordicjm nordicjm requested a review from nordic-krch March 10, 2025 07:17
@nordic-krch
Copy link
Contributor

@bao-eng thanks for that patch. Can you add fix description to commit message?

@bao-eng
Copy link
Author

bao-eng commented Mar 10, 2025

@nordic-krch description added, please review.

@bao-eng bao-eng force-pushed the fix-ble-console branch 2 times, most recently from 7cf786c to 6bd0266 Compare March 10, 2025 18:59
@bao-eng
Copy link
Author

bao-eng commented Mar 10, 2025

@nordic-krch @nordicjm Fixed a few more things to pass compliance checks.
Please approve.

@bao-eng
Copy link
Author

bao-eng commented Mar 12, 2025

@nordic-krch @nordicjm
It looks like the compliance check fails because the runner is missing the PyGObject package:
https://github.com/nrfconnect/sdk-nrf/actions/runs/13772628780?pr=20805

E0611:No name 'Gtk' in module 'gi.repository' (no-name-in-module)
File:scripts/shell/ble_console/BluetoothConsole.py
Line:12
Column:0
 E0611:No name 'Gtk' in module 'gi.repository' (no-name-in-module)
File:scripts/shell/ble_console/TerminalNotebook.py
Line:10
Column:0
 E0611:No name 'Gdk' in module 'gi.repository' (no-name-in-module)
File:scripts/shell/ble_console/TerminalNotebook.py
Line:10
Column:0
 E0611:No name 'Vte' in module 'gi.repository' (no-name-in-module)
File:scripts/shell/ble_console/TerminalNotebook.py
Line:13
Column:0
 W0612:Unused variable 'dir_name' (unused-variable)
File:scripts/shell/ble_console/TerminalNotebook.py
Line:27
Column:12

I added requirements.txt, but I am unsure if it will resolve this issue.
Any advice?

@bao-eng
Copy link
Author

bao-eng commented Mar 12, 2025

@nordic-krch @nordicjm
Well, now, compliance fails due to this:

Error: New files added that are not covered in CODEOWNERS:

scripts/shell/ble_console/requirements.txt

Please add one or more entries in the CODEOWNERS file to cover those files

Please help.

@nordic-krch
Copy link
Contributor

You can add me:

--- a/CODEOWNERS
+++ b/CODEOWNERS
@@ -706,6 +706,7 @@
 /scripts/nrf_provision/fast_pair/*.rst    @nrfconnect/ncs-si-bluebagel-doc
 /scripts/partition_manager/*.rst          @nrfconnect/ncs-aurora-doc
 /scripts/shell/ble_console/**/*.rst       @nrfconnect/ncs-doc-leads
+/scripts/shell/ble_console/*              @nordic-krch
 /scripts/west_commands/sbom/*.rst         @nrfconnect/ncs-si-muffin-doc

@jangalda-nsc
Copy link
Contributor

@bao-eng could you please cherrypick following commit?
371e346
It should help with compliance issue

@bao-eng bao-eng requested review from a team as code owners March 13, 2025 12:58
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 13, 2025
@bao-eng
Copy link
Author

bao-eng commented Mar 13, 2025

@jangalda-nsc thank you!
@nordic-krch added you as an owner, please approve

bao-eng and others added 2 commits March 14, 2025 10:14
Fixed inconsistent use of tabs and spaces
Use keyword arguments to fix PyGTKDeprecationWarning
Fixed string-related type errors
Fixed compliance issues
Renamed 'exit' variable as it shadows a builtin
Added requirments.txt
Added nordic-krch as codeowner of the ble_console app

Signed-off-by: Andrey Basov <dev.basov@gmail.com>
Add dependencies needed by shell/ble_console/BluetoothConsole.py

Signed-off-by: Jan Gałda <jan.galda@nordicsemi.no>
@bao-eng
Copy link
Author

bao-eng commented Mar 14, 2025

@nordic-krch apparently, warnings are also critical; fixed the last one

@nordicjm
Copy link
Contributor

nordicjm commented Apr 3, 2025

@bao-eng needs rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external External contribution
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants