-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
scripts: shell: Fix bluetooth shell #20805
base: main
Are you sure you want to change the base?
Conversation
Thank you for your contribution! Note: This comment is automatically posted and updated by the Contribs GitHub Action. |
@bao-eng thanks for that patch. Can you add fix description to commit message? |
f8be221
to
514b869
Compare
@nordic-krch description added, please review. |
7cf786c
to
6bd0266
Compare
@nordic-krch @nordicjm Fixed a few more things to pass compliance checks. |
6bd0266
to
f2cf813
Compare
@nordic-krch @nordicjm
I added |
@nordic-krch @nordicjm
Please help. |
You can add me:
|
f2cf813
to
8a460d4
Compare
@jangalda-nsc thank you! |
Fixed inconsistent use of tabs and spaces Use keyword arguments to fix PyGTKDeprecationWarning Fixed string-related type errors Fixed compliance issues Renamed 'exit' variable as it shadows a builtin Added requirments.txt Added nordic-krch as codeowner of the ble_console app Signed-off-by: Andrey Basov <dev.basov@gmail.com>
Add dependencies needed by shell/ble_console/BluetoothConsole.py Signed-off-by: Jan Gałda <jan.galda@nordicsemi.no>
8a460d4
to
cf449c4
Compare
|
@nordic-krch apparently, warnings are also critical; fixed the last one |
@bao-eng needs rebase |
Restored the working order of the Bluetooth LE Console application.