Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

samples: wifi: Fix proto type used for RAW sockets #20854

Merged
merged 1 commit into from
Mar 18, 2025

Conversation

rlubos
Copy link
Contributor

@rlubos rlubos commented Mar 11, 2025

It turned out that IPPROTO_RAW is not a valid proto type for AF_PACKET sockets, so it likely won't be supported anymore in the future.

As the samples doing raw TX aren't actually using IP protocols, but just sending raw L2 frames, we could just use ETH_P_ALL as protocol when creating socket instead.

It turned out that IPPROTO_RAW is not a valid proto type for AF_PACKET
sockets, so it likely won't be supported anymore in the future.

As the samples doing raw TX aren't actually using IP protocols, but just
sending raw L2 frames, we could just use ETH_P_ALL as protocol when
creating socket instead.

Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 11, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 11, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 1

Inputs:

Sources:

sdk-nrf: PR head: 7eac7dcaa0ffc16be6fbaaf74a987c3b3cc96ea2

more details

sdk-nrf:

PR head: 7eac7dcaa0ffc16be6fbaaf74a987c3b3cc96ea2
merge base: 13cdec84ac668dbb69831a4fd6c044565a8bf0f8
target head (main): ebbf41e4e3c1aa289bd0e8d958b38e319b122a45
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (2)
samples
│  ├── wifi
│  │  ├── raw_tx_packet
│  │  │  ├── src
│  │  │  │  │ main.c
│  │  ├── shell
│  │  │  ├── src
│  │  │  │  │ wifi_raw_tx_pkt_shell.c

Outputs:

Toolchain

Version: acee3b0b2b
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:acee3b0b2b_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 139
  • ✅ Integration tests
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_lwm2m
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@rlubos
Copy link
Contributor Author

rlubos commented Mar 11, 2025

Is raw_tx_packet sample tested on-board in Jenkins CI? I was only able to verify the data path with debugger, seems to work.

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
B Maintainability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@krish2718
Copy link
Contributor

krish2718 commented Mar 11, 2025

Is raw_tx_packet sample tested on-board in Jenkins CI? I was only able to verify the data path with debugger, seems to work.

AFAIK, it's part of nightly only, @krga2022 please confirm and also validate this PR, probably run nightly CI.

@krish2718 krish2718 requested review from krga2022 and visinor March 11, 2025 11:48
@VivekUppunda
Copy link
Contributor

Is raw_tx_packet sample tested on-board in Jenkins CI? I was only able to verify the data path with debugger, seems to work.

I was able to check this on a nrf7002dk board with the change for raw tx sample. It works.
Thanks for the change

@rlubos
Copy link
Contributor Author

rlubos commented Mar 17, 2025

@D-Triveni Please review, GH requires your ACK.

@rlubos rlubos merged commit 607309d into nrfconnect:main Mar 18, 2025
13 of 14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants