-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
samples: wifi: Fix proto type used for RAW sockets #20854
samples: wifi: Fix proto type used for RAW sockets #20854
Conversation
It turned out that IPPROTO_RAW is not a valid proto type for AF_PACKET sockets, so it likely won't be supported anymore in the future. As the samples doing raw TX aren't actually using IP protocols, but just sending raw L2 frames, we could just use ETH_P_ALL as protocol when creating socket instead. Signed-off-by: Robert Lubos <robert.lubos@nordicsemi.no>
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 7eac7dcaa0ffc16be6fbaaf74a987c3b3cc96ea2 more detailssdk-nrf:
Github labels
List of changed files detected by CI (2)
Outputs:ToolchainVersion: acee3b0b2b Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
Is |
|
AFAIK, it's part of nightly only, @krga2022 please confirm and also validate this PR, probably run nightly CI. |
I was able to check this on a nrf7002dk board with the change for raw tx sample. It works. |
@D-Triveni Please review, GH requires your ACK. |
It turned out that IPPROTO_RAW is not a valid proto type for AF_PACKET sockets, so it likely won't be supported anymore in the future.
As the samples doing raw TX aren't actually using IP protocols, but just sending raw L2 frames, we could just use ETH_P_ALL as protocol when creating socket instead.