Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

samples: wifi: radio_test: Add command to read battery voltage #20876

Merged
merged 2 commits into from
Apr 7, 2025
Merged

samples: wifi: radio_test: Add command to read battery voltage #20876

merged 2 commits into from
Apr 7, 2025

Conversation

imapa
Copy link
Contributor

@imapa imapa commented Mar 12, 2025 •
edited by jira bot
Loading

SHEL-3021: Implemented a new command in the Radio Test sample
to read and display battery voltage in mV.

@imapa imapa marked this pull request as draft March 12, 2025 08:56
@github-actions github-actions bot added manifest changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 12, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 12, 2025 •
edited
Loading

The following west manifest projects have changed revision in this Pull Request:

Name Old Revision New Revision Diff

✅ All manifest checks OK

Note: This message is automatically posted and updated by the Manifest GitHub Action.

@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 12, 2025 •
edited
Loading

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 15

Inputs:

Sources:

sdk-nrf: PR head: 10dfa9f4c295b5e0d570523ae4b9e05daec3a08f

more details

sdk-nrf:

PR head: 10dfa9f4c295b5e0d570523ae4b9e05daec3a08f
merge base: 578095f45245789ca5e45d29a5f13fc8e0f11e59
target head (main): 578095f45245789ca5e45d29a5f13fc8e0f11e59
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (3) 
samples
│  ├── wifi
│  │  ├── radio_test
│  │  │  ├── multi_domain
│  │  │  │  ├── radio_test_subcommands.rst
│  │  │  │  ├── sample_description.rst
│  │  │  │  ├── src
│  │  │  │  │  │ nrf_wifi_radio_test_shell.c

Outputs:

Toolchain

Version: 7cbc0036f4
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:7cbc0036f4_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 141
  • ✅ Integration tests
    • ✅ test-sdk-wifi
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test_ble_nrf_config
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@github-actions github-actions bot added the doc-required PR must not be merged without tech writer approval. label Mar 12, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@kspraveeen kspraveeen added this to the 3.0.0 milestone Apr 1, 2025
@kspraveeen kspraveeen marked this pull request as ready for review April 1, 2025 13:22
@kspraveeen kspraveeen requested a review from a team as a code owner April 1, 2025 13:22
@kspraveeen kspraveeen marked this pull request as draft April 1, 2025 13:27
@kspraveeen kspraveeen force-pushed the vbat_read branch 2 times, most recently from 8b6da07 to b055709 Compare April 1, 2025 14:30
@kspraveeen kspraveeen marked this pull request as ready for review April 1, 2025 14:30
@kspraveeen kspraveeen requested a review from a team as a code owner April 1, 2025 14:30
@github-actions github-actions bot removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 1, 2025
richabp
richabp reviewed Apr 2, 2025
View reviewed changes
Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue with the doc build?

@github-actions github-actions bot removed the manifest label Apr 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 3, 2025 •
edited
Loading

You can find the documentation preview for this PR here.

Preview links for modified nRF Connect SDK documents:

https://ncsdoc.z6.web.core.windows.net/PR-20876/nrf/samples/wifi/radio_test/multi_domain/radio_test_subcommands.html
https://ncsdoc.z6.web.core.windows.net/PR-20876/nrf/samples/wifi/radio_test/multi_domain/sample_description.html

@kspraveeen kspraveeen force-pushed the vbat_read branch 2 times, most recently from e2eeeee to b9f0b3a Compare April 4, 2025 11:53
richabp
richabp approved these changes Apr 4, 2025
View reviewed changes
Copy link
Contributor

@richabp richabp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the changelog entry from this PR as it will be added in #21339.

@imapa @kspraveeen
samples: wifi: radio_test: Add command to read battery voltage
22e946c 
[SHEL-3021]: Implemented a new command in the Radio Test sample
to read and display battery voltage in mV.

Signed-off-by: Mahammadyunus Patil <Mahammadyunus.Patil@nordicsemi.no>
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Apr 7, 2025
@kspraveeen
doc: wifi: radio_test: Subcommand to read battery voltage
10dfa9f 
[SHEL-3094] Document changes for new subcommand

Signed-off-by: Mahammadyunus Patil <Mahammadyunus.Patil@nordicsemi.no>
Signed-off-by: Praveen Kankipati <Praveen.Kankipati@nordicsemi.no>
Signed-off-by: Prasun Sinha <Prasun.Sinha@nordicsemi.no>
@nordicjm nordicjm merged commit 773bdf7 into nrfconnect:main Apr 7, 2025
14 checks passed
@NordicBuilder NordicBuilder mentioned this pull request Apr 7, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kspraveeen kspraveeen kspraveeen left review comments

@nordicjm nordicjm nordicjm approved these changes

@bama-nordic bama-nordic bama-nordic approved these changes

@richabp richabp richabp approved these changes

@sachinthegreen sachinthegreen sachinthegreen approved these changes

@D-Triveni D-Triveni Awaiting requested review from D-Triveni

@krish2718 krish2718 Awaiting requested review from krish2718

@rado17 rado17 Awaiting requested review from rado17

Assignees
No one assigned
Labels
backport v3.0-branch changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. doc-required PR must not be merged without tech writer approval.
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.
7 participants
@imapa @NordicBuilder @nordicjm @bama-nordic @richabp @sachinthegreen @kspraveeen