-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
entropy: 54h20 PSA RNG fixes #20896
base: main
Are you sure you want to change the base?
entropy: 54h20 PSA RNG fixes #20896
Conversation
The following west manifest projects have changed revision in this Pull Request:
⛔ DNM label due to: 1 project with PR revision Note: This message is automatically posted and updated by the Manifest GitHub Action. |
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 4ee343b78b1fb7e68f755c7002da5bc623b62796 more detailssdk-nrf:
nrfxlib:
Github labels
List of changed files detected by CI (9)
Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
You can find the documentation preview for this PR here. |
aa89b5b
to
c4e6382
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just some minor comments.
subsys/nrf_security/src/ssf_secdom/ssf_psa_core_compatibility.c
Outdated
Show resolved
Hide resolved
subsys/nrf_security/src/ssf_secdom/ssf_psa_core_compatibility.c
Outdated
Show resolved
Hide resolved
ping @nrfconnect/ncs-si-muffin @nrfconnect/ncs-aurora @nrfconnect/ncs-protocols-serialization @nrfconnect/ncs-merge |
19eb219
to
46e6572
Compare
return PSA_CRYPTO_SUBSYSTEM_ALL_INITIALISED; | ||
} | ||
|
||
/* This function is defined in psa_crypto_core.h */ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
46e6572
to
956366c
Compare
Add function nrf_rpc_os_fatal_error function to handle fatal_errors using the Zephyr's fatal error hanlding. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Updates the nrf_rpc library to allow initialization of single nrf_rpc groups. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Use nrf_rpc_init_group when ssf_client is being initalized since it will happen before other nrf_rpc groups are initialized. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
Initialize the ssf_client earlier during the boot process during post kernel. ssf_client needs to be initialized before the CONFIG_NRF_802154_SER_RADIO_INIT_PRIO since it is used by the "nRF IEEE 802.15.4" protocol. It also needs to be initialied after the IPC IPC_SERVICE_REG_BACKEND_PRIORITY since the IPC expects the protocol to be initialized. Failing to do that will also trigger an assertion in Zephyr. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
There are two functions which are defined in the psa_crypto_core.h and are implemented in psa_crypto.c which are used by the TLS library. These functions are: psa_can_do_hash psa_can_do_cipher These functions just check if the drivers are initialized before the relevant PSA crypto functions can be used. In the case of SSF there is no initialization needed because the PSA initialization happens inside the secure domain firmware before the application boots. These functions are added in a separate file since they only exist to maintain compatibility with the PSA core from Oberon/mbedTLS and they don't need to forward any call to the secure domain. Signed-off-by: Georgios Vasilakis <georgios.vasilakis@nordicsemi.no>
956366c
to
4ee343b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added comments to nrfxlib PR but this one alone lgtm
This PR is a subset of the following PR here:
#17200
The commits are identical apart from some formatting in the commit which adds PSA compatibility layer for SSF.
This mainly fixes an initialization issue with the nRF IEEE 802.15.4 and IPC, please check the commits messages.