Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nrf7120 hal nordic support #20921

Merged
merged 2 commits into from
Mar 25, 2025

Conversation

Hi-Im-David
Copy link
Contributor

@Hi-Im-David Hi-Im-David commented Mar 13, 2025

Since we can't add nrf7120 SOC definitions and links to NRFX into Zephyr, we need to add it to a hal_nordic folder in ncs. An alternative to this is adding a [noup] commit to sdk-zephyr.

This PR extends the existing cmake files in Zephyr's hal_nordic files so that we can add nrf7120's cmake definitions without adding the code upstream. This is done using the zephyr_library_amend cmake macro.

@Hi-Im-David Hi-Im-David requested review from a team as code owners March 13, 2025 11:41
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 13, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 7

Inputs:

Sources:

sdk-nrf: PR head: 8bbd585f264b86077a0c7d26567f2ae80ac1e3ba

more details

sdk-nrf:

PR head: 8bbd585f264b86077a0c7d26567f2ae80ac1e3ba
merge base: 9bf9ba7b7b744779c4ed5907a79fda5b3140d4f8
target head (main): 9bf9ba7b7b744779c4ed5907a79fda5b3140d4f8
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (5)
CODEOWNERS
modules
│  ├── hal_nordic
│  │  ├── CMakeLists.txt
│  │  ├── nrfx
│  │  │  │ CMakeLists.txt
│  │  │ nrfx_config_ext.h
│  │ modules.cmake

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_8bf7ca4353

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 30
  • ✅ Integration tests
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_serial_lte_modem
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

@Hi-Im-David Hi-Im-David force-pushed the nrf7120-hal-nordic-support branch 2 times, most recently from 37cad5a to 5d55360 Compare March 13, 2025 12:47
@Hi-Im-David Hi-Im-David force-pushed the nrf7120-hal-nordic-support branch from 5d55360 to c9f67a4 Compare March 14, 2025 10:03
@Hi-Im-David Hi-Im-David force-pushed the nrf7120-hal-nordic-support branch from c9f67a4 to edb6ef5 Compare March 17, 2025 12:56
@Hi-Im-David Hi-Im-David requested a review from nordicjm March 17, 2025 12:57
@carlescufi carlescufi requested a review from tejlmand March 17, 2025 14:13
Copy link
Contributor

@carlescufi carlescufi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting for a review from @tejlmand

Copy link
Contributor

@tejlmand tejlmand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General principle for extending upstream module glue code seems ok, though I think there is unneeded copying and code written for the purpose.

@carlescufi carlescufi dismissed their stale review March 17, 2025 16:01

Torsten has taken over.

@Hi-Im-David Hi-Im-David force-pushed the nrf7120-hal-nordic-support branch from edb6ef5 to 41b737d Compare March 19, 2025 15:37
@Hi-Im-David
Copy link
Contributor Author

Hi-Im-David commented Mar 19, 2025

Requires nrfconnect/sdk-zephyr#2634 for nrf7120 code to be able to be built

@Hi-Im-David Hi-Im-David requested a review from tejlmand March 19, 2025 16:41
For compatibility with hal_nordic, nrfx_config files are needed
and nrf7120 SOC macro definitions.

Signed-off-by: David Jewsbury <david.jewsbury@nordicsemi.no>
New folders created to append to hal_nordic

Signed-off-by: David Jewsbury <david.jewsbury@nordicsemi.no>
@Hi-Im-David Hi-Im-David force-pushed the nrf7120-hal-nordic-support branch from 41b737d to 8bbd585 Compare March 24, 2025 16:12
@tejlmand tejlmand merged commit 2d8f677 into nrfconnect:main Mar 25, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants