-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Nrf7120 hal nordic support #20921
Nrf7120 hal nordic support #20921
Conversation
CI InformationTo view the history of this post, clich the 'edited' button above Inputs:Sources:sdk-nrf: PR head: 8bbd585f264b86077a0c7d26567f2ae80ac1e3ba more detailssdk-nrf:
Github labels
List of changed files detected by CI (5)
Outputs:ToolchainVersion: 4ffa2202d5 Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped;
|
37cad5a
to
5d55360
Compare
5d55360
to
c9f67a4
Compare
c9f67a4
to
edb6ef5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Waiting for a review from @tejlmand
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
General principle for extending upstream module glue code seems ok, though I think there is unneeded copying and code written for the purpose.
edb6ef5
to
41b737d
Compare
Requires nrfconnect/sdk-zephyr#2634 for nrf7120 code to be able to be built |
|
For compatibility with hal_nordic, nrfx_config files are needed and nrf7120 SOC macro definitions. Signed-off-by: David Jewsbury <david.jewsbury@nordicsemi.no>
New folders created to append to hal_nordic Signed-off-by: David Jewsbury <david.jewsbury@nordicsemi.no>
41b737d
to
8bbd585
Compare
Since we can't add nrf7120 SOC definitions and links to NRFX into Zephyr, we need to add it to a hal_nordic folder in ncs. An alternative to this is adding a [noup] commit to sdk-zephyr.
This PR extends the existing cmake files in Zephyr's hal_nordic files so that we can add nrf7120's cmake definitions without adding the code upstream. This is done using the zephyr_library_amend cmake macro.