Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport v2.9-nRF54H20-branch] ci: doc: post preview comment after build finishes #20938

Merged

Conversation

NordicBuilder
Copy link
Contributor

Backport ee6552c from #20610.

As of today, preview comment was published just after PR is posted,
so if e.g. build fails, the comment may be misleading. Update the CI
jobs to perform this in 2 steps, so that the docpublish workflow takes
care of posting the comment.

Signed-off-by: Gerard Marull-Paretas <gerard.marull@nordicsemi.no>
(cherry picked from commit ee6552c)
@NordicBuilder NordicBuilder requested a review from a team as a code owner March 14, 2025 09:02
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 14, 2025
@gmarull gmarull added Hotfix Fixes CI or a mistake and removed changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. labels Mar 14, 2025
@gmarull
Copy link
Member

gmarull commented Mar 14, 2025

Merging as hotfix

Copy link

After documentation is built, you will find the preview for this PR here.

@gmarull gmarull merged commit cf8bd8c into v2.9-nRF54H20-branch Mar 14, 2025
15 checks passed
Copy link

You can find the documentation preview for this PR here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Backport Hotfix Fixes CI or a mistake
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants