Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applications: slm: Fix HWFC problems on nRF9151DK #20979

Merged
merged 2 commits into from
Mar 21, 2025

Conversation

SeppoTakalo
Copy link
Contributor

Fix HWFC problems on nRF9151DK

nRF9151DK has interface chip that automatically detects if flow
control is enabled or not. On start up, HWFC pins are floating.

On Zephyr DTS side, nRF9151 CTS pin has pull-up enabled, so if
nRF91 app core boots faster than interface chip, the serial port
might be blocked because of flow control.

Change pull-up to pull-down so nRF91 is allowed to write if interface
chip still has not enabled the HWFC pins.

Drop AT responsed to closed DLCI

If DLCI channel for AT commands has been closed, avoid sending
data to the pipe.

Channel is resumed once remote end connects to the DLCI channel.

@SeppoTakalo SeppoTakalo requested review from a team as code owners March 17, 2025 14:53
@github-actions github-actions bot added the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 17, 2025
@NordicBuilder
Copy link
Contributor

NordicBuilder commented Mar 17, 2025

CI Information

To view the history of this post, clich the 'edited' button above
Build number: 3

Inputs:

Sources:

sdk-nrf: PR head: ac0b78d7d9358a6e8e9585cbcff73533e592762b

more details

sdk-nrf:

PR head: ac0b78d7d9358a6e8e9585cbcff73533e592762b
merge base: 4c623e64e60633b234c20150d040be7e560c5b50
target head (main): 4c623e64e60633b234c20150d040be7e560c5b50
Diff

Github labels

Enabled Name Description
ci-disabled Disable the ci execution
ci-all-test Run all of ci, no test spec filtering will be done
ci-force-downstream Force execution of downstream even if twister fails
ci-run-twister Force run twister
ci-run-zephyr-twister Force run zephyr twister
List of changed files detected by CI (4)
applications
│  ├── serial_lte_modem
│  │  ├── Kconfig
│  │  ├── overlay-cmux.conf
│  │  ├── src
│  │  │  ├── slm_at_host.c
│  │  │  │ slm_cmux.c

Outputs:

Toolchain

Version: 4ffa2202d5
Build docker image: docker-dtr.nordicsemi.no/sw-production/ncs-build:4ffa2202d5_e579f9fbe6

Test Spec & Results: ✅ Success; ❌ Failure; 🟠 Queued; 🟡 Progress; ◻️ Skipped; ⚠️ Quarantine

  • ◻️ Toolchain - Skipped: existing toolchain is used
  • ✅ Build twister
    • sdk-nrf test count: 30
  • ✅ Integration tests
    • ✅ test-fw-nrfconnect-nrf-iot_serial_lte_modem
Disabled integration tests
    • desktop52_verification
    • doc-internal
    • test-fw-nrfconnect-apps
    • test-fw-nrfconnect-ble_mesh
    • test-fw-nrfconnect-ble_samples
    • test-fw-nrfconnect-boot
    • test-fw-nrfconnect-chip
    • test-fw-nrfconnect-fem
    • test-fw-nrfconnect-nfc
    • test-fw-nrfconnect-nrf-iot_cloud
    • test-fw-nrfconnect-nrf-iot_libmodem-nrf
    • test-fw-nrfconnect-nrf-iot_mosh
    • test-fw-nrfconnect-nrf-iot_positioning
    • test-fw-nrfconnect-nrf-iot_samples
    • test-fw-nrfconnect-nrf-iot_thingy91
    • test-fw-nrfconnect-nrf-iot_zephyr_lwm2m
    • test-fw-nrfconnect-nrf_crypto
    • test-fw-nrfconnect-proprietary_esb
    • test-fw-nrfconnect-ps
    • test-fw-nrfconnect-rpc
    • test-fw-nrfconnect-rs
    • test-fw-nrfconnect-tfm
    • test-fw-nrfconnect-thread
    • test-fw-nrfconnect-zigbee
    • test-low-level
    • test-sdk-audio
    • test-sdk-dfu
    • test-sdk-find-my
    • test-sdk-mcuboot
    • test-sdk-pmic-samples
    • test-sdk-sidewalk
    • test-sdk-wifi
    • test-secdom-samples-public

Note: This message is automatically posted and updated by the CI

Copy link

github-actions bot commented Mar 17, 2025

You can find the documentation preview for this PR here.

@SeppoTakalo SeppoTakalo requested a review from a team as a code owner March 19, 2025 13:19
Copy link
Contributor

@MarkusLassila MarkusLassila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing the ready-message was the key in getting the UART to work properly even when the device is started with the power switch.

If DLCI channel for AT commands has been closed, avoid sending
data to the pipe.

Channel is resumed once remote end connects to the DLCI channel.

Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
If there is no certainty that remote end of serial connection has
configured baud rates and flow-control pins correctly, it might
be safer to just skip the "Ready" message from serial port.

Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
@SeppoTakalo SeppoTakalo removed the changelog-entry-required Update changelog before merge. Remove label if entry is not needed or already added. label Mar 21, 2025
@SeppoTakalo SeppoTakalo merged commit 71ba8e3 into nrfconnect:main Mar 21, 2025
15 checks passed
@SeppoTakalo SeppoTakalo deleted the slm_improvements branch March 21, 2025 12:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants